Closed Bug 923354 Opened 11 years ago Closed 11 years ago

Build fails with "The MacroAssembler is not supported on this platform."

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
PowerPC
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: stevensn, Assigned: stevensn)

References

Details

Attachments

(1 file, 1 obsolete file)

923354.patch
828 bytes, patch
Details | Diff | Splinter Review 
Building on ppc fails with the following errors

src/js/src/assembler/assembler/MacroAssembler.h:62:2: error: #error "The MacroAssembler is not supported on this platform."

when building js/src/vm/Runtime.cpp
This appears to have been with bug 921130
Attached patch 923354.patch (obsolete) — — Splinter Review 
Proposed fix - don't include  MacroAssembler.h on non ION platforms
Attachment #813419 - Flags: review?(luke)
Comment on attachment 813419 [details] [diff] [review]
923354.patch

Great, sorry for breakage.  Can you indent the #if'd #include:

#if defined(JS_ION)
# include "assembler/assembler/MacroAssembler.h"
#endif
Attachment #813419 - Flags: review?(luke) → review+
Attached patch 923354.patch — — Splinter Review 
Updated patch that indents the #include.
Attachment #813419 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/790dd24ecef2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: