Closed
Bug 923391
Opened 11 years ago
Closed 11 years ago
Various prompt service cleanup
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file)
|
14.87 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
While writing tests, I noticed that the prompt service isn't doing what I'd expect when the user hits "back" while its open. Namely, if the prompt has a checkbox on it, we act as if the checkbox was unchecked, even if it defaulted to checked. We should ignore changes to the checkbox if the dialog is closed without pressing one of its buttons. I also noticed that in these cases, we're not actually even returning the checkbox value (so we always set the checkbox return value to false). Along the way, I also split complex functions into smaller ones, and removed some unnecessary functions.
|
Assignee | |
Updated•11 years ago
|
Attachment #813453 -
Flags: review?(mark.finkle)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 813453 [details] [diff] [review] Patch v1 Looks like some nice changes and good cleanup
Attachment #813453 -
Attachment is patch: true
Attachment #813453 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7b367ca427b6
https://hg.mozilla.org/mozilla-central/rev/7b367ca427b6
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•