923407 - crash in java.lang.NullPointerException: at org.mozilla.gecko.home.BrowserSearch$SearchAdapter.getCount(BrowserSearch.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[u421692]

This bug was filed from the Socorro interface and is 
report bp-0f12f681-548a-49ef-8252-e76882131003.
=============================================================
Crash found while performing monkey testing (http://developer.android.com/tools/help/monkey.html). It may be a click on an element that was not displayed yet, but logging issue for investigation.

Environment:
Device: HTC Desire HD (Android 2.3.5)
Build: Firefox Aurora 26.0a2 (2013-10-02)

Java Stack Trace 	

java.lang.NullPointerException
	at org.mozilla.gecko.home.BrowserSearch$SearchAdapter.getCount(BrowserSearch.java:723)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:1828)
	at android.os.Handler.handleCallback(Handler.java:587)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:150)
	at android.app.ActivityThread.main(ActivityThread.java:4385)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:849)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:607)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Kyle Wooten]

Thanks!

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Set list adapter to null when destroying BrowserSearch view

AbsListView#PerformClick is a runnable posted to handle ListView clicks, and it's possible that it won't be processed until after onDestroy(). When PerformClick#run runs, it does a number of sanity checks to make sure everything is still valid, including a call to adapter.getCount(): http://androidxref.com/2.3.6/xref/frameworks/base/core/java/android/widget/AbsListView.java#1811

Since we've called onDestroyView and set mList to null, we should also disassociate mList from its adapter to prevent these phantom events. This will make PerformClick#run bail on the 'adapter != null' check (line 1809 in the file linked above).

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 815509 [details] [diff] [review]
Set list adapter to null when destroying BrowserSearch view

Review of attachment 815509 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch.

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/211c60b0c91b

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 815509 [details] [diff] [review]
Set list adapter to null when destroying BrowserSearch view

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new-about-home
User impact if declined: possible NPE
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): Very low risk; just adds one extra line of cleanup.
String or IDL/UUID changes made by this patch: none

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/211c60b0c91b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c21265711c0f

Comment 8

[u421692]

Verified as fixed performing monkey testing (http://developer.android.com/tools/help/monkey.html).

Environment:
Device: HTC Desire HD (Android 2.3.5)
Build: Firefox Nightly 27.0a1 (2013-10-14) / Firefox Aurora 26.0a2 (2013-10-15)