923508 - Overlay on urlbar no longer produces icon, since Firefox 24

Status: RESOLVED WORKSFORME

(Firefox :: Untriaged, defect)

Description

[Ian Nartowicz]

Attachment: cookieController.xpi

User Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20100101 Firefox/17.0 (Beta/Release)
Build ID: 20130911042038

Steps to reproduce:

The attached minimal addon overlays an hbox containing an image on the urlbar, just before the urlbar-icons hbox.  Load this into Firefox 24 or a later version.


Actual results:

No image appears.


Expected results:

A (large!) icon should appear inside the urlbar textbox just before the star.  This worked until Firefox 24.  Now DOM Inspector shows me the overlaid image (zero size, as if hidden) if I inspect without anonymous nodes visible, but it disappears when anonymous nodes are inspected.  Something to do with the way children are merged into XML bindings>

Comment 1

[Ian Nartowicz]

Further info: if I open the toolbar palette, the overlaid image appears, and it remains after I close the palette.  Even if I don't make any customisation changes.

Comment 2

[Ian Nartowicz]

And the real reason :(  The following line of javascript executed in each window:
document.getElementById("urlbar").setAttribute("autocompletesearchparam","");

Not sure if this counts as a bug any more?  Still seems odd and still a regression.

Comment 3

[Ian Nartowicz]

Attachment: Children of the urlbar binding, including the box with an image

Added screenshots showing what DOM Inspector sees.

Comment 4

[Ian Nartowicz]

Attachment: Shwoign anonymous nodes, now hbox with image does not exist

Comment 5

[[:Aleksej]]

WFM with:
2013-01-04-03-08-23-mozilla-central-firefox-20.0a1.en-US.linux-x86_64
2013-06-24-03-10-40-mozilla-central-firefox-24.0a1.en-US.linux-x86_64
firefox-24.0.en-US.linux64
2013-07-01-03-11-15-mozilla-central-firefox-25.0a1.en-US.linux-x86_64
2013-10-21-03-02-03-mozilla-central-firefox-27.0a1.en-US.linux-x86_64

Comment 6

[Adrian Florinescu [:aflorinescu]]

Works for me on:
46.0a1 Build ID 	20160111030207 | Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Note: Guessing that the quality of icon is not in question here, just the fact that is visible.