923635 - DataStore mochitests should use mochitest.ini file

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: dataStore_mochitest.patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 813713 [details] [diff] [review]
dataStore_mochitest.patch

Review of attachment 813713 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/datastore/tests/moz.build
@@ +3,5 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +MOCHITEST_MANIFESTS += ['mochitest.ini']

It's preferred to move this into the parent dir, remove this dir from DIRS there, and remove this moz.build file.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: dataStore_mochitest.patch

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 813753 [details] [diff] [review]
dataStore_mochitest.patch

Review of attachment 813753 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f239497c4d05

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f239497c4d05