923758 - First-time Publish/Claim-on-makes.org action impossible in Goggles

Status: RESOLVED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[David Humphrey (:humph)]

Our UI for publishing with Goggles is suitable for the case that you've already claimed your domain on makes.org.  However, if you haven't, it's impossible to do from Goggles' publishing UI directly.

STR:

1) Make sure you are logged out of webmaker
2) Go to goggles.webmaker.org
3) Click "Active X-Ray Goggles" button in the page
4) Press 'p' to publish
5) Click sign-in, and use an email address you haven't used before
6) Try to claim your domain on makes.org

The UI is pushed off below the visible area in the publish header, and it's impossible to interact with on that page.

Comment 2

[Pomax]

Screen from duplicate bug: https://bug923797.bugzilla.mozilla.org/attachment.cgi?id=813855

this looks like a fragment marker and CSS positioning issue. Taking.

Comment 3

[Pomax]

Attachment: https://github.com/mozilla/goggles.webmaker.org/pull/45

Fix 1 of 2, other fix is in login.webmaker.org (without that fix, you will see multiple empty new-user dialogs getting created each time you try to sign in)

Comment 4

[Pomax]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/186

part 2 of 2. Without this fix the login process will attach multiple empty new user dialogs each time you sign in.

Comment 5

[Thomas Park [:tompark]]

Part 2 looks good, one comment on part 1.

Comment 6

[Pomax]

Comment on attachment 817316 [details] [review]
https://github.com/mozilla/goggles.webmaker.org/pull/45

added the top:140px, looks much nicer, good catch.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/85bce2330faf152497ee92d225fa5d7c1e78b5bc
Merge pull request #186 from Pomax/bug923758

edgecase bug causing the new-user form to add itself multiple times

Comment 8

[Pomax]

both parts landed