923768 - Quadratic Blowup test is broken

Status: RESOLVED FIXED

(L20n :: JS Library, defect)

Description

[Staś Małolepszy :stas]

It should be moved to tests/parser/insecure.  One of my patches in bug 918655 made that change, but maybe it wasn't git-added prior to landing?

Comment 1

[Staś Małolepszy :stas]

Gandalf, did you have a reason for not landing it or was it just an omission?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

The test was removed by your patch, not readded. No reason, I believe I was confused as I was trying to apply your version of the patch against my branch.

Comment 3

[Staś Małolepszy :stas]

It was readded in https://bugzilla.mozilla.org/attachment.cgi?id=811531&action=diff#a/tests/lib/parser/insecure/dos.js_sec2.  Can you please prepare a patch that adds it on master?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Stas, it seems that the file is on master, here: https://github.com/l20n/l20n.js/blob/master/tests/lib/compiler/insecure/dos.js

Should I close this bug?

Comment 5

[Staś Małolepszy :stas]

No.

I think that what we need is to split that file into two tests:

  tests/lib/compiler/insecure/dos.js with the Billion Laughs test
  tests/lib/parser/insecure/dos.js with the Quadratic Blowup test

That's what my patch that I mentioned in comment 3 did.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: 923461.patch

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 820388 [details] [diff] [review]
923461.patch

Review of attachment 820388 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like this is not the right patch?

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: bug923768.diff

Gosh... today is not a good day for me.

Apologies again Stas.

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 820611 [details] [diff] [review]
bug923768.diff

Review of attachment 820611 [details] [diff] [review]:
-----------------------------------------------------------------

No worries, and thanks for fixing this!

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/59039cd21a4f51d86d36b7143be5f8986f32bc4e