923776 - AudioChannelService should not send notifications and/or use callbacks when XPCOM is shutting down.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: service.patch

Comment 2

[Jason Smith [:jsmith]]

I see this blocks a blocker - does this need to be koi+?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Could this lead to a crash?  A la bug 923173?

Comment 4

[(no longer active)]

Comment on attachment 813840 [details] [diff] [review]
service.patch

Review of attachment 813840 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/audiochannel/AudioChannelService.h
@@ +178,5 @@
>    uint64_t mTimerChildID;
>  
>    uint64_t mDefChannelChildID;
>  
> +  bool mDisabled;

Nit: please move the booleans together for better packing.

Comment 5

[Andrea Marchesini [:baku]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/67595062eee3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/67595062eee3