923840 - Mark -moz-appearance:toolbar as opaque on Mac

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: mark-toolbars-opaque

This should improve performance when we have multiple overlapping toolbars (which are expensive to render) as is the case in Australis by mistake.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Markus asked for profiles for this patch, comparing against m-c.

This comparison profile is from Lion, showing an extraction of the TART subtests that have "open" in their name: http://tests.themasta.com/cleopatra/?report=70cd92b3580bc082091e873b7f8914296a08c3e3

Here's a second profile - this one removes the -moz-appearance: toolbar from #TabsToolbar::before, as Markus and I had discussed, along with the patch from this bug. Like the other profile, it compares against m-c on Lion, showing samples from the subtests that have "open" in their name: http://tests.themasta.com/cleopatra/?report=5f867e390dc0a556a9778d2ee9e0eebeaea1ed14

Comment 2

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ad1fa13212

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6ad1fa13212