Closed Bug 924098 Opened 11 years ago Closed 11 years ago

Error in allDownloadsViewOverlay.js: reason is undefined

Categories

(Firefox :: Downloads Panel, defect)

Product:
Firefox
Component:
Downloads Panel
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 27

People

(Reporter: Gijs, Assigned: avp)

Details

(Whiteboard: [good-first-bug][mentor=Gijs][lang=js])

Attachments

(1 file)

Fixed mismatch in variable name |aReason| in allDownloadsViewOverlay.js
1.15 KB, patch
Gijs
: review+
Details | Diff | Splinter Review 
When getting file information fails because the file has been removed, this code runs:

http://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/content/allDownloadsViewOverlay.js?rev=0cec45944008&mark=262#261

Unfortunately, there's a mismatch in the variable names there, and so instead of the code working, it throws a JS error. The code on line 262 should also be using aReason.
good catch!
I would like to work on this bug !
Assignee: nobody → abhishekp.bugzilla
Status: NEW → ASSIGNED
Comment on attachment 815727 [details] [diff] [review]
Fixed mismatch in variable name |aReason| in allDownloadsViewOverlay.js

Looks good to me!
Attachment #815727 - Flags: review?(gijskruitbosch+bugs) → review+
Landed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/1ea7f580adf7

Thanks for the patch!
Whiteboard: [good-first-bug][mentor=Gijs][lang=js] → [good-first-bug][mentor=Gijs][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1ea7f580adf7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][mentor=Gijs][lang=js][fixed-in-fx-team] → [good-first-bug][mentor=Gijs][lang=js]
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: