Closed
Bug 924284
Opened 11 years ago
Closed 10 years ago
[AccessFu] Utter the value of input widgets.
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: yzen, Assigned: yzen)
References
Details
Attachments
(1 file)
11.02 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
In cases such as <input type="range"> and its value changing, we need to utter the value changed.
Comment 1•11 years ago
|
||
.. and the current value when you land on it.
Comment 2•11 years ago
|
||
Attachment #816041 -
Flags: review?(yura.zenevich)
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 816041 [details] [diff] [review] Output accessible values Review of attachment 816041 [details] [diff] [review]: ----------------------------------------------------------------- While running all jsat test I got 1 failure: 63 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_explicit_names.html | Context output is correct for textarea1 (output: text area, This is the text area text., Test Text Area) == (expected: text area, Test Text Area, This is the text area text.) Since the value is now included before the name and the sub-tree is ignored the new output is actually correct. Other than the above, looks good so r=me. ::: accessible/src/jsat/OutputGenerator.jsm @@ +12,5 @@ > const INCLUDE_DESC = 0x01; > const INCLUDE_NAME = 0x02; > +const INCLUDE_VALUE = 0x04; > +const INCLUDE_CUSTOM = 0x08; > +const NAME_FROM_SUBTREE_RULE = 0x10; Perhaps we should use 0x16 to make sure there's never overlap between NAME_FROM_SUBTREE_RULE and INCLUDE_CUSTOM or NAME_FROM_SUBTREE_RULE and INCLUDE_NAME. ::: accessible/tests/mochitest/jsat/output.js @@ +24,5 @@ > var context = new PivotContext(accessible, oldAccessible); > var output = aGenerator.genForContext(context).output; > > isDeeply(output, expected, > + "Context output is correct for " + aAccOrElmOrID + " (output: " + output.join(', ') + ') == (expected: ' + expected.join(', ') + ')'); NIT: line too long, mixed single and double quotes.
Attachment #816041 -
Flags: review?(yura.zenevich) → review+
Comment 4•11 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #3) > Comment on attachment 816041 [details] [diff] [review] > Output accessible values > > Review of attachment 816041 [details] [diff] [review]: > ----------------------------------------------------------------- > > While running all jsat test I got 1 failure: > > 63 ERROR TEST-UNEXPECTED-FAIL | > chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/ > test_explicit_names.html | Context output is correct for textarea1 (output: > text area, This is the text area text., Test Text Area) == (expected: text > area, Test Text Area, This is the text area text.) > > Since the value is now included before the name and the sub-tree is ignored > the new output is actually correct. > Oops, fixed. > Other than the above, looks good so r=me. > > ::: accessible/src/jsat/OutputGenerator.jsm > @@ +12,5 @@ > > const INCLUDE_DESC = 0x01; > > const INCLUDE_NAME = 0x02; > > +const INCLUDE_VALUE = 0x04; > > +const INCLUDE_CUSTOM = 0x08; > > +const NAME_FROM_SUBTREE_RULE = 0x10; > > Perhaps we should use 0x16 to make sure there's never overlap between > NAME_FROM_SUBTREE_RULE and INCLUDE_CUSTOM or NAME_FROM_SUBTREE_RULE and > INCLUDE_NAME. > I think you are thinking in decimal :) > ::: accessible/tests/mochitest/jsat/output.js > @@ +24,5 @@ > > var context = new PivotContext(accessible, oldAccessible); > > var output = aGenerator.genForContext(context).output; > > > > isDeeply(output, expected, > > + "Context output is correct for " + aAccOrElmOrID + " (output: " + output.join(', ') + ') == (expected: ' + expected.join(', ') + ')'); > > NIT: line too long, mixed single and double quotes. Fixed.
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e82e8f1c85f Landed. Yura, if you are doing any work on value changed events, lets keep it in this bug.
Whiteboard: [leave open]
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Whiteboard: [leave open]
Updated•10 years ago
|
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•