924749 - Signed/unsigned comparison build warnings PathCairo.cpp

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

Three build warnings in PathCairo.cpp:
{
gfx/2d/PathCairo.cpp:273:31 [-Wsign-compare] comparison between signed and unsigned integer expressions
gfx/2d/PathCairo.cpp:277:27 [-Wsign-compare] comparison between signed and unsigned integer expressions
gfx/2d/PathCairo.cpp:287:40 [-Wsign-compare] comparison between signed and unsigned integer expressions
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

The first and third loop variables are compared against vector::size(), which returns vector<foo>::size_type;  the second loop var is compared against 'uint32_t pointCount', so I made that one a uint32_t.  So I changed the loop vars' types to match.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v2 (using std::vector<cairo_path_data_t>::size_type) [Nope, this is too ugly]

oops; forgot to qref. That first patch used size_t instead of the more-pedantically-correct std::vector<cairo_path_data_t>::size_type (which this version uses)

(I'm happy with either; feel free to reject this and r+ the other patch if you'd prefer the concise version)

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 814719 [details] [diff] [review]
fix v2 (using std::vector<cairo_path_data_t>::size_type) [Nope, this is too ugly]

Actually, looks like Jeff's on vacation. Bas, could you review?

(If you're put off by the vector<...>::size_type cruft, see other patch for a prettier size_t version)

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 814718 [details] [diff] [review]
fix v1

Review of attachment 814718 [details] [diff] [review]:
-----------------------------------------------------------------

I sadly have to admit I prefer this even though it's strictly a tiny bit less correct :).

Comment 5

[Daniel Holbert [:dholbert]]

Thanks!

(I prefer size_t, too; and IIRC, it's guaranteed to be equivalent as long as we're not instantiating vector<> with a custom allocator)

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4c3caf8f741

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4c3caf8f741