924852 - "StateString”:identifier not found

Status: RESOLVED DUPLICATE of bug 925705

(Core :: Networking: Cache, defect)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20131007194344

Steps to reproduce:

 disable moz_logging, CacheEntry.cpp(164) : error C3861: "StateString”:identifier not found.

Comment 1

[Toady]

Same in 27.0a1 branch

With or without disabling moz_logging

./netwerk/cache2/CacheEntry.cpp(164) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(456) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(544) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(615) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(1018) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(1032) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(1059) : Error C3861 'StateString': Identifier not found
./netwerk/cache2/CacheEntry.cpp(1216) : Error C3861 'StateString': Identifier not found

CacheEntry.cpp Failed, Return code 1

<nkcache2_s.lib.desc>: Found Error

Make.py Libs Failed, return code 2

Comment 2

[Toady]

Modifying  ./netwerk/cache2/CacheEntry.h Line:(245)

#ifdef MOZ_LOGGING
  static char const * StateString(uint32_t aState);
#endif

Changing it to:

#ifdef MOZ_LOGGING
  static char const * StateString(uint32_t aState);
#else
static char const * StateString(uint32_t aState);
#endif

Seems to fix the issue probably not the best patch but its working.

Successfully compile with moz_logging enabled/disabled

Comment 3

[[e-mail]]

(In reply to Toady from comment #2)
> Modifying  ./netwerk/cache2/CacheEntry.h Line:(245)
> 
> #ifdef MOZ_LOGGING
>   static char const * StateString(uint32_t aState);
> #endif
> 
> Changing it to:
> 
> #ifdef MOZ_LOGGING
>   static char const * StateString(uint32_t aState);
> #else
> static char const * StateString(uint32_t aState);
> #endif
> 
> Seems to fix the issue probably not the best patch but its working.
> 
> Successfully compile with moz_logging enabled/disabled

just remove the #if #endif shall make it work

Comment 4

[Toady]

This issue has been fixed https://bugzilla.mozilla.org/show_bug.cgi?id=925705