92503 - window title should show non ASCII in MacOSX

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

We should show non ASCII in MacOS X window title. In the past, there are no API
to do that, but in the MacOS X , there seems have one. I try OmniWeb on MacOS X
and they can display that correctly on window title. We should find out how they
do that.

Comment 1

[Frank Tang]

Hum... Here is some research result. Not 100% sure how to do it yet.
in
http://developer.apple.com/techpubs/macosx/Carbon/HumanInterfaceToolbox/WindowManager/Window_Manager/index.html
 SetWindowTitleWithCFString
OSStatus SetWindowTitleWithCFString (
    WindowRef inWindow, 
    CFStringRef inString
);
And this api will take a CFStrineRef 

And from
http://developer.apple.com/techpubs/macosx/CoreFoundation/Overview/CFOverview/index.html
it seems CFString is holding unicode.

Comment 2

[Frank Tang]

we probably should create the CFStringRef from Unicode by calling
CFStringCreateWithCharacters (see
http://developer.apple.com/techpubs/macosx/CoreFoundation/Overview/CFOverview/index.html
)

Comment 3

[Frank Tang]

The code which may want to change is in widget/src/mac/nsMacWindow.cpp

1169 NS_IMETHODIMP nsMacWindow::SetTitle(const nsString& aTitle)
1170 {
1171 Str255 title;
1172 // unicode to file system charset
1173 nsMacControl::StringToStr255(aTitle, title);
1174 ::SetWTitle(mWindowPtr, title);
1175 return NS_OK;
1176 }

Comment 4

[Frank Tang]

Attachment: patch Use SetWindowTitleWithCFString

Comment 5

[Frank Tang]

can someone review this one?
Somehow when I run the carbon build on Mac, it will crash if I have this patch. 
Not sure why?
I have not try on MacOS X yet. 

Comment 6

[Greg K.]

Attachment: Basic testcase HTML with Shift JIS-encoded TITLE text.

Comment 7

[Greg K.]

Changing platform from PC to Macintosh as it refers to Mac OS X.

Comment 8

[Greg K.]

Targeting to Future, but since there's a fix-in-hand for this, let's get it
targeted to something pre-1.0.

Comment 9

[Steve Dagley]

greg, if you're not the owner of a bug please do not change the target milestone.  
Unless of course you have the agreement of the bug owner

Comment 10

[Greg K.]

Whatever.

Comment 11

[Frank Tang]

can someone review the code ?

Comment 12

[Frank Tang]

My patch work nicely on MacOS X without problem. When I run in MacOS 9 with the
carbon build, it will crash the second time it set a non ASCII title to the
title bar. 

Comment 13

[Mike Pinkerton (not reading bugmail)]

if you can provide a stacktrace of where it crashes, we can file a bug with 
apple. i'd prefer not to check in anything we know crashes on carbon os9 since 
even though we don't really support it, it might hork up embedding clients who 
want to use it.

Comment 14

[Frank Tang]

Attachment: better fix which won't crash on MasOS 9

Comment 15

[Frank Tang]

I have no way to produce a stack for the crash on MacOS 9 with the early patch. 
It simply stop running and exist the running section without drop into debugger. 
The new patch work better since it only go to the new api if it is running on 
MacOSX or later. 

Comment 16

[Simon Fraser [no longer active]]

sr=sfraser

Comment 17

[Frank Tang]

set to m94

Comment 18

[Greg K.]

Reference also bug 36689 for this functionality under Classic Mac OS.

Comment 19

[Greg K.]

Reference also bug 74753 for this bug under Linux.

Comment 20

[Greg K.]

The patch for bug 22871 can be applied to Mac OS X once this bug is fixed.

Comment 21

[Frank Tang]

fixed and check in for MacOS X.

Comment 22

[Andreas Becker]

Switching qa contact to ruixi.  Rui, please verify.

Comment 23

[Rui Xu]

This bug has been fixed and confirmed with build 080905 and build 081005.