Closed
Bug 925193
Opened 11 years ago
Closed 11 years ago
domUtils.getCSSValuesForProperty() does not return "unset" in autocomplete values
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: miker, Assigned: heycam)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.27 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
getCSSValuesForProperty() fails to return "unset" in autocomplete values. const DOMUtils = Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils); DOMUtils.getCSSValuesForProperty("color").indexOf("unset"); // returns -1
Comment 1•11 years ago
|
||
Er, yes, we needed to add "unset" to http://hg.mozilla.org/mozilla-central/file/a141e39bf6da/layout/inspector/src/inDOMUtils.cpp#l595 I hate this duplication stuff. :(
Assignee | ||
Comment 2•11 years ago
|
||
Ah, right. Lucky we don't add CSS-wide keywords very often.
Assignee: nobody → cam
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #815189 -
Flags: review?(bzbarsky)
Comment 4•11 years ago
|
||
Comment on attachment 815189 [details] [diff] [review] patch r=me especially if you fix the tests?
Attachment #815189 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] (Vacation Oct 12 - Oct 27) from comment #4) > r=me especially if you fix the tests? Yes that would help wouldn't it. I'll update layout/inspector/tests/test_bug877690.html before landing.
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dad2edca27e
Status: NEW → ASSIGNED
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dad2edca27e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•