925497 - "No vibration" preference should apply globally

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[sean.m456]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_5) AppleWebKit/536.30.1 (KHTML, like Gecko) Version/6.0.5 Safari/536.30.1

Steps to reproduce:

Turned off all vibration through Settings -> Sound -> Vibration


Actual results:

Home button vibration was still active.


Expected results:

Home button vibration should have ceased.

Comment 1

[Joshua Smith [:joshua-s]]

I can confirm this.

Comment 2

[Joshua Smith [:joshua-s]]

Oh, sorry, this is the System app.

Basically we would need to change this line so that it only runs if the vibrate preference is set to true.
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/hardware_buttons.js#L161

Comment 3

[Joshua Smith [:joshua-s]]

Where does the vibration preference code live in the Settings app?

Comment 4

[Joshua Smith [:joshua-s]]

That was answered by :vingtetun.  An idea that I had was to turn off vibration globally (e.g. disable navigator.vibrate) in gecko when this preference is set to "false."  Does this sound good?

Comment 5

[Joshua Smith [:joshua-s]]

If no one responds soon, I will assume that it is, and implement it accordingly.

Comment 6

[Johannes Bauer]

I'm unfamiliar with the code base, but would this also disable the vibration that occurs when ringing? Because it is quite useful to have ringtone settings "Completely silent", "Only vibration", "Noise + (VibrationEnabled ? Vibration : Nothing)". Do you know what I mean?

Comment 7

[Joshua Smith [:joshua-s]]

Need-infoing the UX people!

Comment 8

[Johannes Bauer]

I don't really understand -- do you want me to do something? Or are you saying you asked the "UX people" (who is that?) something? Please clarify.

Comment 9

[Joshua Smith [:joshua-s]]

(In reply to Johannes Bauer from comment #8)
> I don't really understand -- do you want me to do something? Or are you
> saying you asked the "UX people" (who is that?) something? Please clarify.

Oh, sorry.  UX stands for the User Experience team.  They are the ones who specify the interaction flows.  You do not have to do anything.  I need-infoed them to get their feedback.

Comment 10

[Stephany Wilkes]

Hi Joshua, please let us know exactly what you're looking for feedback on. Is it the patch in comment #2? Also, please note that the UX team is responding to koi+ and koi? bugs first, to get 1.2 out, followed by 1.3? and 1.3+, which is in line with QA and release priority. We are responding to bugs like that after those, so a delay in response is normal at this time.

Comment 11

[Joshua Smith [:joshua-s]]

Hello Stephany!

I was actually referring to https://bugzilla.mozilla.org/show_bug.cgi?id=925497#c4.  I completely understand about the delay.

Comment 12

[Stephany Wilkes]

Got it. To that end, I've flagged Neo, who is UX for Settings on System Platform. Neo, the idea (Gaia side) is about disabling vibration (see above). It has Gecko impact, though, so I've also flagged Tim to assess that impact.

Comment 13

[Neo Hsieh [:neo]]

Hi Everyone, 
I think if user turn off the vibrate in settings,
in theory, that means users don't want any vibrate when they received calls.

But in this kind of layout design, users will aussume that option will control whole items. 
So I will prefer to turn off whole vibrate function.  Not just for phone call. 

What do you think ?

Comment 14

[Joshua Smith [:joshua-s]]

Neo:

That is exactly what I was thinking in comment 4.  Good to hear that you agree :)

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I have no opinion on this. Although I would imagine the vibration give people a definite feedback on capacitive hardware buttons (which is the case for our current low-end phones).

Comment 16

[Joshua Smith [:joshua-s]]

Would someone else like to take this?

Comment 17

[BMO Automation]

Firefox OS is not being worked on