925666 - [Buri][REG][Gallery]The MS always crash when save picture edited

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect, P1)

Description

[sync-1]

Firefox os  v1.1
 Mozilla build ID:20130916041201
 
 Created an attachment (id=534193)
 log
 
 DEFECT DESCRIPTION:
  The MS always crash when save picture edited
 
 REPRODUCING PROCEDURES:
  1.Launch Gallery app
  2.select one picture to view
  3.Edit the pic
  4.Change its Effects,press finish button->MS crash->ko
  
 EXPECTED BEHAVIOUR:
  ko:the edited picture should be saved
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
  Mid
 
 REPRODUCING RATE:
  3/5
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[Ray REN]

Hi I check the behavior  when loading
pics from sdcard, you are edit a pic and save it, the gallery easily crash.

Comment 2

[sync-1]

Clone from brother

Comment 3

[sync-1]

Attachment: log

Comment 4

[sync-1]

Clone from brother

Comment 5

[sync-1]

Attachment: video

Comment 6

[sync-1]

Clone from brother

Comment 7

[sync-1]

Attachment: log

Comment 8

[Ray REN]

When loading pics from sdcard, it consume some memory, and the same time the user edit and save pic also consume some memory. This time gallery easily killed by itself. Please help check and fix it. Thanks.

Comment 9

[David Flanagan [:djf]]

Ray, are you saying that this bug only occurs if you try to use the edit feature while the gallery is scanning the sdcard and processing images?

Does it happen when all the images on the sdcard are from the camera, or only when the sdcard has external images on it? 

The gallery's performance is much better when it works with images from the Camera and when the Camera includes an EXIF preview images that is at least as large as the screen size.

I see that this is marked leo? Are there still any 1.1 builds that are accepting patches?  I thought we were done with leo bugs...

In any case, if we need to patch this for 1.1, I'd say the simplest thing to do is disable the edit button while scanning is happening. That is better than crashing.

Diego: Do you want to take this one and do a simple "disable editing while scanning" patch?

Comment 10

[Ray REN]

(In reply to David Flanagan [:djf] from comment #9)
> Ray, are you saying that this bug only occurs if you try to use the edit
> feature while the gallery is scanning the sdcard and processing images?

Yes. 

> Does it happen when all the images on the sdcard are from the camera, or
> only when the sdcard has external images on it? 
> 

Both kinds of circumstances will occur. And external images reproduce easily.

> The gallery's performance is much better when it works with images from the
> Camera and when the Camera includes an EXIF preview images that is at least
> as large as the screen size.
> 
> I see that this is marked leo? Are there still any 1.1 builds that are
> accepting patches?  I thought we were done with leo bugs...

Yeah, we could add patches by upgrade packs.

> 
> In any case, if we need to patch this for 1.1, I'd say the simplest thing to
> do is disable the edit button while scanning is happening. That is better
> than crashing.
> 
> Diego: Do you want to take this one and do a simple "disable editing while
> scanning" patch?

Comment 11

[Diego Marcos [:dmarcos]]

I can have a look into this

Comment 12

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi David and Diego,

Does bug 915001 releate to this bug?
They all have some problems when saving the edited image.

Comment 13

[Diego Marcos [:dmarcos]]

I made a patch with the solution that :djf suggested: we disable the edit button while mediadb scans pictures from storage. This is a temporary solution to prevent the gallery to crash.

Comment 14

[Diego Marcos [:dmarcos]]

Attachment: pullRequest.html

Comment 15

[Ray REN]

(In reply to Diego Marcos from comment #14)
> Created attachment 817548 [details]
> pullRequest.html

Hi Diego,

I add your patch and test,it works. But I can also edit pics when scaning. And the step like follows: 
1.Launch Gallery app
2.click a pic  to preview.
3.Slide view on previous picture or the next picture.
4.Then click edit button quickly, user also can edit pics and this issue can happen.

Comment 16

[Diego Marcos [:dmarcos]]

Thanks. Good catch! I updated the pull request to deal with the cases when the user pans to the previous or next image

Comment 17

[David Flanagan [:djf]]

Comment on attachment 817548 [details]
pullRequest.html

John,

Would you take this review for me?

Comment 18

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sure. I will do it today.

Comment 19

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 817548 [details]
pullRequest.html

Thanks for this patch. It looks good.

Comment 20

[Diego Marcos [:dmarcos]]

Merged on master:

https://github.com/mozilla-b2g/gaia/commit/6b0a8108eac92ab3b5e73946c57f750fe8744356

Comment 21

[Jason Smith [:jsmith]]

Mass-modify - removal of no longer relevant blocking flags.