925790 - Fix Octane-raytrace regression

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

See the huge big Octane-raytrace regression on AWFY. It's a regression from bug 918584.

It looks like we're no longer caching add-props when the property exists on the prototype. The attached patch fixes it. shu: if you can think of a better fix, please steal.

Comment 2

[Nathan Froyd [:froydnj]]

Is it possible that this fixes the V8 talos regression, too?  See e.g.

http://mzl.la/1hIlyXX

with corresponding cset range:

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=027a7386406f&tochange=6fef99317f21

which has bug 918584 landed.

Comment 3

[Nicolas B. Pierron [:nbp]]

(In reply to Nathan Froyd (:froydnj) from comment #2)
> Is it possible that this fixes the V8 talos regression, too?  See e.g.

Yes, this is likely the same issue, as octane inherits most of v8 benchmarks.

Comment 4

[Shu-yu Guo [:shu]]

Comment on attachment 815897 [details] [diff] [review]
Patch

Review of attachment 815897 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch!

Comment 5

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35167e0cc319

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/35167e0cc319