92589 - View Use Stylesheet doesn't work on frames

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[[e-mail]]

Comment 1

[[e-mail]]

Attachment: Proposed Patch

Comment 2

[Asa Dotzler [:asa]]

neil, can you explain a little more about the specifics of this problem and the
solution you've attached? Thanks.

pchen, can you take a look at this and if it's sound please add your r= and help
us find an sr? Thanks.

blake, if this looks good and pchen can r= can you sr= or help us find an sr=?
Thank.

Comment 3

[[e-mail]]

The problem is that the stylesheet menu only gets/sets the alternate stylesheets
for the top window. This is next to useless when it is a frameset document.

My code attempts to do two things:
1. Enumerate all frames and subframes for alternate stylesheets
2. Enable and disable alternate stylesheets in those frames that define them

This means that if two frames define the same stylesheet names then they will be
enabled/disabled together, but if they define independent stylesheets names then
they will have separate control.

Comment 4

[sairuh (rarely reading bugmail)]

cc-ing hyatt.

Dave, what do you think about this?

Comment 5

[Peter Trudelle]

->jaggernaut

Comment 6

[jag (Peter Annema)]

Comment on attachment 43786 [details] [diff] [review]
Proposed Patch

>Index: navigator.js
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v
>retrieving revision 1.355
>diff -u -r1.355 navigator.js
>--- navigator.js	2001/07/24 06:58:13	1.355
>+++ navigator.js	2001/07/27 16:55:22
>@@ -1225,10 +1246,21 @@
>   itemNoOptStyles.setAttribute("checked", noOptionalStyles);
> }
> 
>-function stylesheetSwitch(forDocument, title)
>-{
>-  var docStyleSheets = forDocument.styleSheets;
>+function stylesheetInFrame(frame, title) {
>+  var docStyleSheets = frame.document.styleSheets;
> 
>+  for (i = 0; i < docStyleSheets.length; ++i) {

This should probably be |for (var i = 0; ...|

r=jag if you fix that.

Comment 7

[[e-mail]]

Attachment: Cleaned Up Patch

Included fastnav.js in patch.
Removed unused attributes.
Fixed JS warnings.

Comment 8

[jag (Peter Annema)]

Comment on attachment 60478 [details] [diff] [review]
Cleaned Up Patch

>Index: navigator.js
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v
>retrieving revision 1.409
>diff -u -r1.409 navigator.js
>--- navigator.js	2001/12/04 22:38:29	1.409
>+++ navigator.js	2001/12/05 12:15:03

>+function getAllStyleSheets(frameset)
>+{
>+  var styleSheetsArray = getStyleSheetArray(frameset);
>+  dump(styleSheetsArray.length + ' stylesheets');

I'm sure you meant to take that out :-)

Nice optimizations by moving the oncommand up and cloning the None item.

r=jag if you remove that dump.

Comment 9

[jag (Peter Annema)]

Comment on attachment 60478 [details] [diff] [review]
Cleaned Up Patch

>Index: navigator.js
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v
>retrieving revision 1.409
>diff -u -r1.409 navigator.js
>--- navigator.js	2001/12/04 22:38:29	1.409
>+++ navigator.js	2001/12/05 12:15:03

>+function getAllStyleSheets(frameset)
>+{
>+  var styleSheetsArray = getStyleSheetArray(frameset);
>+  dump(styleSheetsArray.length + ' stylesheets');

I'm sure you meant to take that out :-)

Nice optimizations by moving the oncommand up and cloning the None item.

r=jag if you remove that dump.

Comment 10

[[e-mail]]

Attachment: Removed dump

Two out of three isn't bad :-)

Comment 11

[Matthew T (active 1999-2002)]

CCing alecf for sr=.

Comment 12

[jag (Peter Annema)]

Comment on attachment 60481 [details] [diff] [review]
Removed dump

r=jag

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 60481 [details] [diff] [review]
Removed dump

sr=[e-mail]

Comment 14

[jag (Peter Annema)]

Neil, can you check this in or should I?

Comment 15

[jag (Peter Annema)]

-> Neil

Comment 16

[jag (Peter Annema)]

Checked in.