925997 - Search results with lengthy names cause overlap issues

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot.png

build: 1.2 on unagi from Oct 11th (https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-aurora-unagi-eng/latest/)
device: Unagi

steps to reproduce:
1. Search for Dictionary in the e.me search box
2. Notice that the marketplace app 'Dictionary (by Dictionary.com)' is among the search results
3. Notice how the app underneath (urban dictionary) is pushed down causing the app icon to partially overlap with the app name.

observed behavior:
Search results with lengthy names cause alignment issues in the grid resulting in overlap of the app icon with the app name. See screenshot

Comment 1

[Amir Nissim (:amirn)]

Attachment: Redirect to PR

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Amir, the removal of <li> css height causes the separator to "jump" a few times before the items above have fully rendered.

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 8337758 [details] [review]
Redirect to PR

r+, but see ran's comment 2.

Also I suggest moving all those values to a single place (be it Utils or Result.js), but it's not critical.
https://github.com/mozilla-b2g/gaia/pull/14020/files?w=1#diff-2a0d8bf37d05354a2469f5d3ffd03aa5R5

Comment 4

[Amir Nissim (:amirn)]

thanks guys. updated PR.

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 8337758 [details] [review]
Redirect to PR

Looking good

Comment 6

[Amir Nissim (:amirn)]

landed

Comment 7

[Amir Nissim (:amirn)]

landed
https://github.com/mozilla-b2g/gaia/commit/4ad796b196d468bdb231beba4392acbc90a74e96

Comment 8

[Jason Smith [:jsmith]]

Clearing nom - this is already part of 1.3, so this doesn't need to be triaged.