926443 - [zh-CN] review major update of translation

Status: RESOLVED WONTFIX

(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)

Description

[Axel Hecht [:Pike]]

Hi holywen,

I just rejected the sign-off for 25. I think it's too big a change to take at this point.

In particular, I'd like to understand why you're changing the plural form?

Another thing I found was some inconsistencies when using English words and acronyms, some are all caps, some are all lowercase, some are regular case.

I also see (a) etc additions for accesskeys in at least browser.dtd.

downloadsHistory.label got untranslated.

Generally speaking, this looks like a redo much more than an update?

Comment 1

[Shaohua Wen]

Hi Axel,
  There are quite many refinements, and also we missed the date to checkin to aurora, so we did the updates in beta chanel directly, that's why  you see too big change happend.
  
  Would it be OK that we fix the plural form (we missed this change in the review before checkin) and the downloadHistory.label issue and request another approval? I will also remove the additions for accesskeys.

  The English words are copied from the original english string, we don't have a standard for this yet. do you have some suggestions for it?

Br.
Holy

Comment 2

[Axel Hecht [:Pike]]

So, the plural form changed in July from 0 to 1 (no plural to English plurals), in http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-CN/rev/7e4c16007f79, and you started using different wordings for 1 and non-1. Is that just style or is https://developer.mozilla.org/en/docs/Localization_and_Plurals just wrong about plurals and Chinese?

Another nit, I found some inconsistent changes to quoting, ' vs “%1$S”, some change one way, some the opposite way around.

As for landing, I'm OK with the work focusing on 25, but you should land on both aurora and beta (just push the same revisions), and test the aurora builds to make sure they're working as expected.

Comment 3

[Shaohua Wen]

We found in some case the "no plural" does not work for Chinese some time ago, that's why some time we also need to using different wordingsfor 1 and non-1, so the plural form 1 should be correct.

For quoting   we are not strictly checking since we found in English version the quota seems not consist as well.

This case is after the aurora is not fully done but the lift from aurora to Beta is already done since the time line passed. so we are not able to test on aurora, so we'll try to finish on time later to avoid the same situation.

Comment 4

[Shaohua Wen]

<Loop China Community mail list>

Comment 5

[Axel Hecht [:Pike]]

Sorry guys, but I'm going to reject this. I'm doing this based on two arguments:

We just recently had a case where a "minor QA fix" turned into an l10n update on the release channel, because it was the wrong translation in context. Being burned just recently, I have to be pretty risk averse.

The second reason is that I compared the state on beta with the state on aurora, and at least some changes from beta get undone, and there are a lot of merge conflicts if I try to merge aurora and beta myself. The work for Firefox 26 doesn't seem to be a consistent update with the changes to 25.

That makes this update just too risky for me to take. I do appreciate that you tried to get 25 into good shape, but this didn't work out this time. Today is the last day that I can take updates to l10n, so we'll need to let 25 slip.

Comment 6

[Shaohua Wen]

Hi Axel,
  Considering not release it or we might have some translation bugs, I want to vote for still release it.

Comment 7

[Axel Hecht [:Pike]]

Sorry, but this is just too late.

Comment 8

[Jack_No1]

Is this a conversation between a zh_CN localization team member and a firefox developer? It seems that the reason leads to the translation problems in firefox 25 is the delay of submission and severe word change, is that correct?
In addition, when could this problem be fixed? In 25.0.1 or in 26.0 after 6 weeks?

Comment 9

[Axel Hecht [:Pike]]

We'll ship the next update to zh-CN with Firefox 26.

To clarify, I'm commenting on behalf of release drivers. As for why, comment 5 is as good as I can describe it