926972 - Modify pash.py on hgssh to support a pushlog command

Status: RESOLVED FIXED

(Infrastructure & Operations :: Change Requests, task)

Description

[Ben Kero [:bkero]]

As a requirement for migrations hg to local disk, a 'pushlog' command must be added to the pash.py script which serves SSH access of hg.mozilla.org. The diff follows:

    --- a/hg_helper.py
    +++ b/hg_helper.py
    @@ -318,6 +318,12 @@ def serve (cname):
                 else:
                     sys.stderr.write ('edit usage: ssh hg.mozilla.org edit [userrepo delete] - WARNING: will not prompt!
    ')
                     sys.exit (1)
    +    elif ssh_command.startswith ('pushlog ') and (cname != 'hg.ecmascript.org'):
    +        args = ssh_command.replace ('pushlog', '').split()
    +        if check_repo_name (args[0]):
    +            fh = open("%s/%s/.hg/pushlog2.db" % (doc_root[cname], args[0]))
    +            print(fh.read())
    +            fh.close()
         else:
             sys.stderr.write ('No interactive commands allowed here!
    ')
             sys.exit (1) 

The change was tested and performs as expected.

CAB requested information:

Date: 2013-10-17
Time: 0600
Systems affected: hgssh1 and hgssh2
End-user impact: users will be able to request a pushlog by issuing the following command: ssh -l [e-mail] hg.mozilla.org pushlog mozilla-central
Maintenance plan and timeline: ?
Rollback plan: copy original file back into place, revert file in svn, update puppet masters
Notification mechanisms: send an email to concerned parties, CAB
Person on point: Me. Others should be minimally affected. Releng could bring someone to do additional review if they like.

Comment 1

[Shyam Mani [:fox2mike]]

Approved by the CAB on 16 Oct to be done on 17 Oct.

Comment 2

[Ben Kero [:bkero]]

This push was rolled out. Confirmed working.

bkero@Gluttony:~$ ssh -l [e-mail] hg.mozilla.org pushlog build/tools > bt.sql
bkero@Gluttony:~$ file bt.sql
bt.sql: SQLite 3.x database