926991 - split robocop (rc) into 4 chunks

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Wesley Johnston (:wesj)]

Trying to land a bunch of tests in bug 757481, I keep getting blues [1]. Until 883539 is fixed, I'd like to add an rc4 so that I can land.

[1] https://tbpl.mozilla.org/?tree=Try&rev=7926ed2a24aa

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Of course, this is only needed for Android 4.0 / panda.

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug926991mh.patch

Comment 3

[Kim Moir [:kmoir] ET]

Attachment: bug926991bbconfigs.patch

Comment 4

[Jordan Lund (:jlund)]

Comment on attachment 817576 [details] [diff] [review]
bug926991mh.patch

Review of attachment 817576 [details] [diff] [review]:
-----------------------------------------------------------------

neat. I didn't realize how similar this was to desktop unittests in mozharness!

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 817578 [details] [diff] [review]
bug926991bbconfigs.patch

Review of attachment 817578 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me!

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 817576 [details] [diff] [review]
bug926991mh.patch

Review of attachment 817576 [details] [diff] [review]:
-----------------------------------------------------------------

::: configs/android/android_panda_releng.py
@@ +118,5 @@
>          "jsreftest-2": ["--total-chunks=3", "--this-chunk=2"],
>          "jsreftest-3": ["--total-chunks=3", "--this-chunk=3"],
>      },
>      "all_robocop_suites": {
>          #plain is split

I think this comment can come out too? Legacy copy/paste from somewhere else? (mochitest-plain perhaps?)

Comment 7

[Kim Moir [:kmoir] ET]

Comment on attachment 817576 [details] [diff] [review]
bug926991mh.patch

removed comment too

Comment 8

[Kim Moir [:kmoir] ET]

Attachment: bug926991try.patch

patch to update trychooser

Comment 9

[Jordan Lund (:jlund)]

Comment on attachment 817960 [details] [diff] [review]
bug926991try.patch

Review of attachment 817960 [details] [diff] [review]:
-----------------------------------------------------------------

::: trychooser/index.html
@@ +242,5 @@
>              <li><label><input type="checkbox" value="mochitest-gl">mochitest-gl</label></li>
>              <li><label><input type="checkbox" value="robocop-1">robocop-1</label></li>
>              <li><label><input type="checkbox" value="robocop-2">robocop-2</label></li>
>              <li><label><input type="checkbox" value="robocop-3">robocop-3 <span class="info">(not x86)</span></label></li>
> +             <li><label><input type="checkbox" value="robocop-4">robocop-4 <span class="info">(not x86)</span></label></li>

looks good to me. how come we specify not x86 for only chunks 3 and now 4? I'm having trouble seeing where we use robocop-{1-4} differently by platform bits?

Comment 10

[Kim Moir [:kmoir] ET]

verified on tbpl