927132 - e10s: "chrome://browser/content/content.js: TypeError: Services.search is undefined" when reloading about:home

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Run a debug build with e10s enabled from the command line
2. Load about:home
3. Watch stderr
4. Reload about:home

RESULT:
System JS : ERROR chrome://browser/content/content.js:91
                     TypeError: Services.search is undefined

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This looks like a regression from bug 900865.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

How so? Does the global-sharing for content scripts work differently in e10s builds?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #2)
> How so? Does the global-sharing for content scripts work differently in e10s
> builds?

I'm not sure why the access is considered an error. That might be worth investigating, since we use Services elsewhere in that file.

The problem I was worried about is that Services.search.defaultEngine will (I assume) only be correct in the parent process, so we should be sending its value in a message from the parent.

I'll try to look at this more closely next week.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Oh, I see - the search service initialization in the child must be failing for some reason.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-about-home

I just passed the search engine name down from the parent.

Comment 7

[Mike de Boer [:mikedeboer]]

Comment on attachment 821368 [details] [diff] [review]
fix-about-home

Review of attachment 821368 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for working on this!

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I filed bug 930456 to cover the general problem of the search service not working in child processes.

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6a4d3416d87

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c6a4d3416d87