927524 - Closing a window with a sidebar open does not fire a 'detach' event

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

Will reported this by email.  Also should make sure that the 'hide' event fires.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

The 'hide' event also does not fire, and I'm not sure if it should.  I'm guessing that both the 'detach' and 'hide' event should fire when the window housing them closes.  I'll confirm that is what happens with panels and some other modules.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> The 'hide' event also does not fire, and I'm not sure if it should.  I'm
> guessing that both the 'detach' and 'hide' event should fire when the window
> housing them closes.  I'll confirm that is what happens with panels and some
> other modules.

Yep, this is how panel works.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

Pointer to Github pull-request

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> The 'hide' event also does not fire, and I'm not sure if it should.  I'm
> guessing that both the 'detach' and 'hide' event should fire when the window
> housing them closes.  I'll confirm that is what happens with panels and some
> other modules.

To be fare panel actually get's hidden when you try to close window so it's more like a side effect.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

r+ with the `.then(null, assert.fail)` added and the panel's test removed from this patch.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ec4a1b4efe603ea76b675593b54304e8c3ac5089
Bug 927524 Closing a window with a sidebar open does not fire a detach or hide event

https://github.com/mozilla/addon-sdk/commit/e3d41c3201ae6564ecd99ddf321a172eb92571b9
Merge pull request #1267 from erikvold/927524

Bug 927524 Closing a window with a sidebar open does not fire a detach or hide event r=@zer0

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

[Approval Request Comment]
User impact if declined: A new Jetpack api will not emit events when they should be.  Early adopters will have to write work arounds.

Testing completed (on m-c, etc.): yes

Risk to taking this patch (and alternatives if risky): Low/No risk

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Same question as in https://bugzilla.mozilla.org/show_bug.cgi?id=923348#c5

Comment 9

[bhavana bajaj [:bajaj]]

Comment on attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

Clearing the nom still the question above is clear.