Closed
Bug 927525
Opened 11 years ago
Closed 11 years ago
mozharness clobberer should retry
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: ffledgling)
References
Details
(Keywords: sheriffing-untriaged, Whiteboard: [simple][mozharness])
Attachments
(1 file)
|
1.36 KB,
patch
|
catlee
:
feedback+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
Sometimes we can't contact the clobberer service for various reasons. We should retry a few times before giving up. This probably means wrapping this code in a loop: http://hg.mozilla.org/build/mozharness/file/283c75b9580f/mozharness/mozilla/purge.py#l101
|
||
Updated•11 years ago
|
Keywords: sheriffing-untriaged
|
Assignee | |
Comment 1•11 years ago
|
||
Patch adds retry. using mozharness.base.script's retry ,instead of a loop, as per aki's suggestion. catlee can you please look at this and tell me if this is okay, or if any kind of changes are required? Thanks!
Assignee: nobody → ffledgling
Attachment #819049 -
Flags: feedback?(catlee)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 819049 [details] [diff] [review] Bug927525.patch Review of attachment 819049 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks!
Attachment #819049 -
Flags: feedback?(catlee) → feedback+
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 819049 [details] [diff] [review] Bug927525.patch https://hg.mozilla.org/build/mozharness/rev/c04300e53715
Attachment #819049 -
Flags: checked-in+
|
||
Comment 4•11 years ago
|
||
merged to production mozharness
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Component: General Automation → Mozharness
You need to log in
before you can comment on or make changes to this bug.
Description
•