Closed
Bug 927886
Opened 11 years ago
Closed 11 years ago
Impprove test_import_contacts_from_SIM
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Firefox OS Graveyard
Gaia::UI Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: AlinT, Assigned: AlinT)
Details
Attachments
(1 file)
We are currently returning the Contacts app after tapping import_from_sim: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/contacts/test_import_contacts_from_sim.py#L25 when we should actually go back in the Contacts app then assert that the contacts are there
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → alin.trif
|
|
Assignee | |
Comment 1•11 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•11 years ago
|
Attachment #818895 -
Flags: review?(zcampbell)
Attachment #818895 -
Flags: review?(moz.teodosia)
Attachment #818895 -
Flags: review?(florin.strugariu)
Attachment #818895 -
Flags: review?(bob.silverberg)
Attachment #818895 -
Flags: review?(andrei.hutusoru)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 818895 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931 LGTM
Attachment #818895 -
Flags: review?(andrei.hutusoru) → review+
|
||
Updated•11 years ago
|
Attachment #818895 -
Flags: review?(florin.strugariu) → review+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 818895 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931 LGTM.
Attachment #818895 -
Flags: review?(moz.teodosia) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 818895 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12931 r+ here too!
Attachment #818895 -
Flags: review?(zcampbell)
Attachment #818895 -
Flags: review?(bob.silverberg)
Attachment #818895 -
Flags: review+
|
|
||
Comment 5•11 years ago
|
||
Merged https://github.com/mozilla-b2g/gaia/commit/383089a06d8f33953b3f18fd80d577fc60b5971d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•