927917 - Middle-clicking on the items in the History subview should open them in a new tab

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Middling-clicking on the items in the History subview should open them in a new tab

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

We don't need to do anything for Recently Closed Tabs or Recently Closed Windows since they have their own opening semantics (tabs reopen as new tabs, and windows reopen as a new window).

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 818517 [details] [diff] [review]
Patch

Review of attachment 818517 [details] [diff] [review]:
-----------------------------------------------------------------

I checked if 'click' and 'command' are not both fired when a history item is clicked. They are not, so this is ready to roll.

Thanks for fixing this!

::: browser/components/customizableui/src/CustomizableWidgets.jsm
@@ +82,5 @@
>                let item = doc.createElementNS(kNSXUL, "toolbarbutton");
>                item.setAttribute("label", title || uri);
>                item.setAttribute("tabindex", "0");
> +              item.addEventListener("command", function (aEvent) {
> +                onHistoryVisit(uri, aEvent, item);

what I find fascinating (and not related to this bug/ patch) is that we use `item` inside a closure. Is it because `item` is block-scoped that it doesn't always reference to the last set `item` when the loop terminated?

It's just a pattern that intrigues me as I've been trained to call the alarm when spotted.

> I just checked this in the Web Console and the theory above is true. Awesome, long live block scoping!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Thanks for the quick review!

https://hg.mozilla.org/projects/ux/rev/777283896d61

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

This patch also needs to be merged to m-c.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Nevermind, I shouldn't look at BZ when I'm sleep deprived. This patch only touched CustomizableWidgets.jsm.

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/777283896d61