Closed Bug 928174 Opened 11 years ago Closed 7 years ago

[Meta][l12y] Truncated and Overlapping text in 1.2

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: delphine, Unassigned)

References

Details

(Whiteboard: LocRun1.2) 

Although less frequent and different than in 1.1(see Bug 892075), there are still text truncation issues throughout 1.2. 

This happens across different 1.2 shipping locales, and includes some English occurrences as well.

Let's track these here to get a better view of where it needs to be solved and how we can solve this
Depends on: 889150
Whiteboard: LocRun1.2
No longer blocks: 880905
Depends on: 929082
No longer depends on: 893208
Summary: [Meta][l12y] Truncated text in 1.2 → [Meta][l12y] Truncated and Overlapping text in 1.2
No longer depends on: 893229
No longer depends on: 880520
Depends on: 929173
Depends on: 929184
Depends on: 929186
Depends on: 929237
Depends on: 929244
Depends on: 892734
No longer blocks: 889919
Depends on: 889919
Depends on: 929258
Depends on: 929265
Depends on: 929271
Depends on: 929549
Depends on: 929560
Depends on: 929577
Depends on: 892689
Depends on: 929589
Depends on: 929593
Depends on: 929599
Depends on: 929597
Depends on: 929605
Depends on: 929607
Depends on: 929611
Depends on: 929612
Depends on: 929614
Depends on: 929615
Depends on: 929626
Depends on: 929629
Depends on: 929630
Depends on: 929633
Depends on: 929646
Depends on: 929672
Depends on: 929688
Depends on: 929693
Depends on: 929695
Depends on: 929699
Depends on: 929708
Depends on: 929712
Depends on: 929713
Depends on: 830717
Depends on: 929721
Depends on: 929729
Depends on: 929736
Depends on: 929737
Depends on: 929740
Depends on: 929743
Depends on: 929746
Depends on: 929748
Depends on: 929749
Depends on: 929752
Depends on: 929753
Depends on: 929756
Depends on: 929768
Depends on: 929774
Depends on: 929787
Depends on: 929789
Depends on: 930096
Depends on: 930103
Depends on: 930113
Depends on: 930110
Depends on: 930137
Depends on: 885812
Depends on: 930165
Depends on: 930171
Depends on: 930180
Depends on: 930181
Depends on: 930224
Depends on: 930230
Depends on: 930234
Depends on: 930236
Depends on: 928526
Depends on: 930249
Depends on: 930248
Depends on: 930251
Depends on: 930259
Depends on: 930266
Depends on: 930268
Depends on: 930291
Depends on: 930311
Depends on: 930330
Depends on: 930333
Depends on: 930487
Depends on: 930579
Depends on: 930320
Depends on: 930617
Depends on: 930620
Depends on: 930626
Depends on: 930628
Depends on: 930637
Depends on: 930648
Depends on: 930649
Depends on: 930658
Depends on: 930661
Depends on: 930668
Depends on: 930669
Depends on: 886409
Depends on: 930682
Depends on: 930687
Depends on: 930694
Depends on: 930698
Depends on: 930700
Depends on: 930704
Depends on: 930705
Depends on: 930721
Depends on: 930726
Depends on: 930739
Depends on: 930757
Depends on: 930759
Depends on: 930770
Depends on: 930777
Depends on: 930780
Depends on: 930786
Depends on: 930807
Depends on: 930814
Depends on: 930822
Depends on: 931057
Depends on: 931063
Depends on: 931067
Depends on: 893103
Depends on: 931076
Depends on: 931088
Depends on: 931106
Depends on: 931121
Depends on: 931162
Depends on: 931182
Depends on: 931193
Depends on: 931205
Depends on: 931207
Depends on: 931209
Depends on: 931213
Depends on: 931220
Depends on: 931222
Depends on: 931234
Depends on: 931235
Depends on: 931236
Depends on: 931228
Depends on: 931240
Depends on: 931241
Depends on: 931248
Depends on: 931250
Depends on: 931253
Depends on: 931255
Depends on: 931211, 931214, 931221, 931258
Depends on: 931264
Depends on: 931265
Depends on: 931278
Depends on: 931280
Depends on: 931284
Depends on: 931290
Depends on: 931291
Depends on: 931294
Depends on: 931498
Depends on: 931500
Depends on: 931501
Depends on: 931502
Depends on: 931503
Depends on: 931505
Depends on: 931506
Depends on: 931512
Depends on: 931516
Depends on: 931520
Depends on: 931522
Depends on: 931524
Depends on: 931525
Depends on: 931532
Depends on: 931536
Depends on: 931535
Depends on: 931539
Depends on: 931538
Depends on: 931545
Depends on: 931546
Depends on: 931548
Depends on: 931552
Depends on: 931553
No longer depends on: 931548
Depends on: 931574
Depends on: 931577
Depends on: 931583
Depends on: 931598
Depends on: 931601
Depends on: 931605
Depends on: 931606
Depends on: 931607
Depends on: 931609
Depends on: 931579
Depends on: 931584
Depends on: 931585
Depends on: 931594
Depends on: 931614
Depends on: 931620
Depends on: 931621
Depends on: 931623
Depends on: 931624
Depends on: 931625
Depends on: 931626
Depends on: 931629
Depends on: 931630
Depends on: 931633
Depends on: 931636
Depends on: 931639
Depends on: 931646
Depends on: 931647
Depends on: 893972
Depends on: 932128
Depends on: 932132
Depends on: 932139
Depends on: 932140
Depends on: 932403
Depends on: 932415
Depends on: 937403
Depends on: 937749
Depends on: 937776
Depends on: 937785
Depends on: 937795
Depends on: 937804
Depends on: 937813
Depends on: 937856
Depends on: 937885
Depends on: 937891
Depends on: 937892
Depends on: 937920
Depends on: 937940
No longer depends on: 937776
No longer depends on: 937785
No longer depends on: 937795
Depends on: 937841
No longer depends on: 937885
Depends on: 938210
Depends on: 938236
Depends on: 938238
Depends on: 938269
Depends on: 938276
No longer depends on: 938236
I’m not sure I understand what’s going on here… Are all these bugs regressions? I.e. did those same strings fit in 1.1?

Bug 927785 might have helped, but this bug is only about list items in the Settings app. Can we have an idea of what apps and app components are concerned by these truncations?

As an example: how much would it help if we reduced the font-size in the title bars? I think it would greatly improve the readability, even for English — and we could even reduce the title bar height, thus getting more vertical screen estate for the content… Is there a bug for that by any chance?
Kaze, this bug covered some truncation issues in title bars: bug #908300. Not sure that's exactly what you're looking for.
Depends on: 938367
Thanks for the pointer Stephany, but how many of the bugs tracked in this meta-bug would be solved by bug 908300?

Or to put it another way: as a developer, what would be the most efficient way for me to help to reduce these truncations? If we can identify which application or which UI component is raising the most truncation issues, we could focus on those and do our best to fix them properly.

Besides, I think we should watch these most-impacted apps or UI components closely to make sure we (= developers) haven’t introduced regressions in the latest branch. I’m a bit scared that l10n-related regressions are not enough taken in consideration during the development process, and I’m rather confident we could improve this by relying on some of our most talented volunteers (hi Théo! ^^) if we knew where to look at.

I hope this clarifies my question a bit. Sorry for being unclear. :-/
Depends on: 938372
Depends on: 938397
Depends on: 938399
Depends on: 938404
Depends on: 938413
Depends on: 938425
Blocks: 894127
Depends on: 938436
Depends on: 938452
Depends on: 938448
Depends on: 938457
Depends on: 938667
Depends on: 930233
No longer blocks: 936684
Depends on: 936684
Depends on: 885946
Depends on: 938701
Depends on: 938696
Depends on: 938708
Depends on: 938732
Depends on: 938747
Depends on: 938749
Depends on: 938758
Depends on: 938761
Depends on: 938762
Depends on: 938765
Depends on: 938769
Depends on: 938774
Depends on: 938788
Depends on: 938789
Depends on: 938793
Depends on: 938427
Depends on: 938798
Depends on: 938802
Depends on: 938807
Depends on: 938808
Depends on: 938306
Depends on: 938810
Depends on: 938811
Depends on: 938813
Depends on: 938815
Depends on: 938822
Depends on: 938828
Depends on: 938833
Depends on: 938836
Depends on: 938838
Depends on: 938839
Depends on: 938840
Depends on: 938841
Depends on: 938842
Depends on: 938843
Depends on: 938847
Depends on: 938858
Depends on: 938866
Depends on: 938874
Depends on: 938876
Depends on: 938882
Depends on: 938891
Depends on: 938894
Depends on: 938900
Depends on: 938903
Depends on: 938906
Depends on: 830166
Depends on: 938912
Depends on: 938913
Depends on: 938919
Depends on: 938921
Depends on: 938933
Depends on: 938934
Depends on: 938936
Depends on: 938940
Depends on: 938942
Depends on: 939168
Depends on: 939176
Depends on: 939179
Depends on: 939187
Depends on: 939199
Depends on: 930157
Depends on: 939208
Depends on: 939215
Depends on: 939216
Depends on: 929603
Depends on: 803238
Depends on: 939223
Depends on: 939236
Depends on: 939237
Depends on: 939240
Depends on: 939251
Depends on: 939263
Depends on: 939278
No longer depends on: 938448
No longer depends on: 938457
Depends on: 939286
No longer depends on: 938696
No longer depends on: 938708
Depends on: 939293
No longer depends on: 938765
No longer depends on: 938793
No longer depends on: 938815
No longer depends on: 938891
No longer depends on: 938900
Depends on: 939300
Depends on: 894171
Depends on: 939320
Depends on: 939321
Depends on: 939334
Depends on: 939338
Depends on: 939340
Depends on: 939341
Depends on: 939349
Depends on: 939352
Depends on: 939356
Depends on: 939827
Depends on: 939869
Depends on: 939878
Depends on: 939879
Depends on: 939894
Depends on: 939898
Depends on: 939904
Depends on: 939908
Depends on: 939910
Depends on: 939937
Depends on: 939964
Depends on: 939973
Depends on: 939995
Depends on: 940042
Depends on: 940043
Depends on: 940055
Depends on: 940056
Depends on: 940057
Depends on: 940060
Depends on: 940063
Depends on: 940064
Depends on: 940066
Depends on: 940067
Depends on: 940076
Depends on: 940077
Depends on: 940079
Depends on: 940081
Depends on: 940089
Depends on: 940091
Depends on: 940098
Depends on: 940105
Depends on: 940108
Depends on: 940109
Depends on: 940110
Depends on: 940113
Depends on: 940115
Depends on: 940120
Depends on: 940121
Depends on: 940122
Depends on: 940135
Depends on: 940137
Depends on: 940434
Depends on: 940456
Depends on: 940467
Depends on: 940486
Depends on: 940492
Depends on: 940516
Depends on: 940522
Depends on: 940545
Depends on: 940547
Depends on: 940567
Depends on: 940580
Depends on: 940606
Depends on: 940611
Depends on: 940616
Depends on: 940627
Depends on: 940680
Depends on: 940741
Depends on: 940744
Depends on: 931617
Depends on: 938408
Depends on: 938448
Depends on: 931142
Depends on: 893413
Depends on: 905224
Depends on: 893850
Depends on: 893492
No longer depends on: 930165
No longer blocks: 894127
Depends on: 894127
Depends on: 892735
Depends on: 892758
Depends on: 892786
Depends on: 940476
Depends on: 931543
Depends on: 931541
Depends on: 937368
Trying again to start the discussion on this issue… let me rephrase. I think there are three main reason why we have truncated or overlapping strings:

 A: some text containers are just too short; they are hardly large enough for English and there’s no extra space for longer locales (e.g. Latin locales), which should be considered as a UX bug. Bug 908300 is a good example.

 B: some text containers have been reduced since the last branch, which should be considered as a *regression* imho. Bug 927785 is a good example of such a regression.

 C: some localizers do not test on HVGA devices, and don’t pay enough attention to the string sizes. This can happen a lot and there’s not much we can do to prevent it — it’s just part of the localization process.

Now the question is: how many of this long list of bugs would fall in each bucket?

As a developer, I’m mostly worried about A: and B: here — we should do what it takes to avoid breaking the work of our l10n contributors. Delphine, would it be possible to file two meta bugs for that? One for too small containers, one for unwanted container width reduction? And do you think it’d be worth it?
Flags: needinfo?(lebedel.delphine)
Another reason that Flod pointed out is that we reuse our l10n strings too much in different contexts — e.g. in the link and in a header for the Settings app. This is a mistake that we don’t do with XUL localization.

As Flod suggested, a good start would be to have a naming convention for entities: XXX-button, XXX-title, XXX-label.
(In reply to Fabien Cazenave [:kaze] from comment #5)
> As Flod suggested, a good start would be to have a naming convention for
> entities: XXX-button, XXX-title, XXX-label.

Note that having "coding guidelines for .properties file" would also help us in other areas:
* More readable files: I count at least 6 different ways of writing a simple statement like X=Y, if you don't believe me check settings.properties.
* Help with the constant lack of l10n comments. Knowing if the label is used for a message, a header or a button etc. would help me understand if I'm looking at a verb or a noun in English, and would also help me identify a string that needs QA without looking at the code.
Depends on: 944174
Depends on: 944189
Depends on: 945473
Depends on: 950463
Sorry for the late reply. Let's wait and see what comes out of our meeting this Thursday before we go forwards with this :)
Flags: needinfo?(lebedel.delphine)
Old bug, closing as WORKSFORME
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.