Closed
Bug 928361
Opened 11 years ago
Closed 11 years ago
Images in themes/platform/tabs/ don't need a 'tab' prefix.
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 27.0
People
(Reporter: jsbruner, Assigned: jsbruner)
References
Details
Attachments
(3 files, 3 obsolete files)
6.39 KB,
patch
|
jsbruner
:
review+
|
Details | Diff | Splinter Review |
16.13 KB,
patch
|
jsbruner
:
review+
|
Details | Diff | Splinter Review |
17.09 KB,
patch
|
jsbruner
:
review+
|
Details | Diff | Splinter Review |
Bug 923648 moved all tab-related images from the icons directory on Windows and Linux into a tabs directory instead. However, each image still contains a 'tab' prefix, which is no longer needed, since the image path will include the 'tab' part.
Comment 1•11 years ago
|
||
You could also shorten the url's from list-style-image: url(chrome://messenger/skin/tabs/tabDragIndicator.png); to list-style-image: url(tabs/DragIndicator.png); like it is already done for the tab background.
Assignee | ||
Comment 2•11 years ago
|
||
This removes the "tab" prefix on Linux. (I'm splitting these up to ease the reviewing process)
Attachment #822676 -
Flags: review?(richard.marti)
Assignee | ||
Comment 3•11 years ago
|
||
Removes "tab" prefix on OS X.
Attachment #822677 -
Flags: review?(richard.marti)
Assignee | ||
Comment 4•11 years ago
|
||
Removal of "tab" for Windows.
Attachment #822678 -
Flags: review?(richard.marti)
Comment 5•11 years ago
|
||
Comment on attachment 822676 [details] [diff] [review] Linux removal. Review of attachment 822676 [details] [diff] [review]: ----------------------------------------------------------------- Looks good and works. r=me
Attachment #822676 -
Flags: review?(richard.marti) → review+
Comment 6•11 years ago
|
||
Comment on attachment 822677 [details] [diff] [review] OS X removal. Review of attachment 822677 [details] [diff] [review]: ----------------------------------------------------------------- Looks also good. I haven't tested it but I suppose you have done it on your Mac. r=me
Attachment #822677 -
Flags: review?(richard.marti) → review+
Comment 7•11 years ago
|
||
Comment on attachment 822678 [details] [diff] [review] Windows removal. Review of attachment 822678 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the two comments fixed. ::: mail/themes/windows/jar.mn @@ +212,5 @@ > skin/classic/messenger/icons/identity.png (mail/icons/identity.png) > skin/classic/messenger/icons/tick.png (mail/icons/tick.png) > skin/classic/messenger/icons/error.png (mail/icons/error.png) > skin/classic/messenger/icons/cancel.png (mail/icons/cancel.png) > + skin/classic/messenger/tabs/arrow-left.png (mail/tabs/aarrow-left.png) With only one a in arrow-left it would find the image and build. @@ +222,5 @@ > + skin/classic/messenger/tabs/activeMiddle.svg (mail/tabs/activeMiddle.svg) > + skin/classic/messenger/tabs/activeStart.svg (mail/tabs/activeStart.svg) > + skin/classic/messenger/tabs/backgroundEnd.png (mail/tabs/backgroundEnd.png) > + skin/classic/messenger/tabs/backgroundMiddle.png (mail/tabs/backgroundMiddle.png) > + skin/classic/messenger/tabs/backgroundStart.png (mail/backgroundStart.png) If it would be (mail/tabs/backgroundStart.png) then it would also build.
Attachment #822678 -
Flags: review?(richard.marti) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Updated commit message...
Attachment #822676 -
Attachment is obsolete: true
Attachment #822800 -
Flags: review+
Assignee | ||
Comment 9•11 years ago
|
||
Fixed a build problem and updated commit message.
Attachment #822677 -
Attachment is obsolete: true
Attachment #822801 -
Flags: review+
Assignee | ||
Comment 10•11 years ago
|
||
Fixed problems. Thanks Richard!
Attachment #822678 -
Attachment is obsolete: true
Attachment #822802 -
Flags: review+
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/9a89f368426f https://hg.mozilla.org/comm-central/rev/cd97cbc98824 https://hg.mozilla.org/comm-central/rev/031684b6571a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → Thunderbird 27.0
You need to log in
before you can comment on or make changes to this bug.
Description
•