Closed
Bug 928827
Opened 11 years ago
Closed 11 years ago
SelectStyleSheet does not move the cursor to proper line/column if any editor is already loaded
Categories
(DevTools :: Style Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: Optimizer, Assigned: Optimizer)
Details
Attachments
(1 file, 1 obsolete file)
|
1.64 KB,
patch
|
Optimizer
:
review+
|
Details | Diff | Splinter Review |
since the object _styleSheetToSelect is non null if *any* stylesheet in style editor was opened earlier, the selectStyleSheet method exits early without doing anything but updating the to be selected sheet. This fails when the same stylesheet was opened at the time of the call as it does not update the cursor to the newly asked positions.
Attachment #819599 -
Flags: review?(mihai.sucan)
|
||
Updated•11 years ago
|
Attachment #819599 -
Flags: review?(mihai.sucan) → review+
|
Assignee | |
Comment 1•11 years ago
|
||
Patch to land. Just added a commit message.
Assignee: nobody → scrapmachines
Attachment #819599 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #820166 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 2•11 years ago
|
||
Patch looks good. Thank you Girish and Paul.
|
||
Comment 3•11 years ago
|
||
Pushed this along with a bunch of other checkin-neededs to try: https://tbpl.mozilla.org/?tree=Try&rev=2c426f843d08
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5ba7172333e2
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5ba7172333e2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•