928937 - test_delete_contact.py cannot find contact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently the test_delete_contact.py test is failing because it cannot find the contact it wants to delete.  This is occurring because it need to use:

  self.contact['givenName'][0]

Instead of:

  self.contact['givenName']

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/12979

Comment 2

[Zac C (:zac)]

Comment on attachment 819734 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/12979

Depends on https://bugzilla.mozilla.org/show_bug.cgi?id=928922, but fundamentally sound.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Thanks!  Merged:

  https://github.com/mozilla-b2g/gaia/commit/6a016296fad599e05ac679cb37b83b62909d5005

Comment 4

[Bob Silverberg [:bsilverberg]]

This fix should have included a change to the manifest file reenabling the test. Can that please be done?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

This test still needs bug 928922 to land before it will work.  This was just one of two things that was broken.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Closing this again as bug 928922 will re-enable the test once it lands.