Closed
Bug 929345
Opened 11 years ago
Closed 11 years ago
bug history/activity shouldn't collapse multi-line values to a single line
Categories
(Bugzilla :: User Interface, defect)
Bugzilla
User Interface
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: glob, Assigned: glob)
Details
Attachments
(1 file, 2 obsolete files)
619 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
if you have a custom textarea, when viewing a bug's history the field's contents are always shown on a single line, making it difficult to read. bugzilla should honour line breaks when displaying activity entries.
Attachment #820170 -
Flags: review?(dkl)
Comment 2•11 years ago
|
||
Comment on attachment 820170 [details] [diff] [review] 929345_1.patch Review of attachment 820170 [details] [diff] [review]: ----------------------------------------------------------------- Looks good (and familiar) and works well. r=dkl
Attachment #820170 -
Flags: review?(dkl) → review+
Updated•11 years ago
|
Flags: approval?
Flags: approval4.4?
Comment 3•11 years ago
|
||
Comment on attachment 820170 [details] [diff] [review] 929345_1.patch Template Toolkit already has a builtin html_line_break filter which does exactly that.
Attachment #820170 -
Flags: review-
Updated•11 years ago
|
Flags: approval?
Flags: approval4.4?
thanks lpsolit :)
Attachment #820170 -
Attachment is obsolete: true
Attachment #823346 -
Flags: review?(simon)
Comment 5•11 years ago
|
||
Comment on attachment 823346 [details] [diff] [review] 929345_2.patch No, html_line_break simply converts \n into <br>. It does no escaping. So you need to write: [% foo FILTER html FILTER html_line_break %] The order of the filters is important (else <br> would be escaped too).
Attachment #823346 -
Flags: review?(simon) → review-
Attachment #823346 -
Attachment is obsolete: true
Attachment #823361 -
Flags: review?(LpSolit)
Comment 7•11 years ago
|
||
Comment on attachment 823361 [details] [diff] [review] 929345_3.patch r=LpSolit
Attachment #823361 -
Flags: review?(LpSolit) → review+
Updated•11 years ago
|
Flags: approval?
Updated•11 years ago
|
Flags: approval? → approval+
Comment 8•11 years ago
|
||
Target milestone?
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/bug/activity/table.html.tmpl Committed revision 8816.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 5.0
You need to log in
before you can comment on or make changes to this bug.
Description
•