Closed
Bug 929525
Opened 11 years ago
Closed 11 years ago
Email manual setup 'account' fields make automatic spelling corrections
Categories
(Firefox OS Graveyard :: Gaia::E-Mail, defect)
Firefox OS Graveyard
Gaia::E-Mail
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 Sprint 3 - 10/25
People
(Reporter: brion, Assigned: brion)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release) Build ID: 20130910160258 Steps to reproduce: * build and install v1-train or v1.2 on ZTE Open * open Email app * set up new account * fill in name/address fields, then click "manual setup"... * tap into IMAP or SMTP "account" field * type "brion"... * type "." Actual results: * search suggestions popped up, and when we press "."... * suddenly "brion." is replaced with "Briony." Expected results: * should not show spell suggestions and just let me type "brion.vibber" without it changing from under me halfway through
Assignee | ||
Comment 1•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/13017
Assignee | ||
Comment 2•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/13022 <- fixed pull request to be against master instead of v1.2
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #821031 -
Flags: review?(bugmail)
Comment 4•11 years ago
|
||
Comment on attachment 821031 [details] [review] Disable spell corrections in email manual config username fields Thanks for the fix! Indeed, this is a case where we do not want auto-correct doing its thing. I will merge this once the travis build goes green (I had to restart a test run) and mark the bug fixed/etc. once that happens.
Attachment #821031 -
Flags: review?(bugmail) → review+
Comment 5•11 years ago
|
||
It took a lot of clicking, but the build went green. landed on gaia/master: https://github.com/mozilla-b2g/gaia/pull/13028 https://github.com/mozilla-b2g/gaia/commit/96bec788aac8311f53df0e490b0c4d97a7ae0e74 Thanks again for the fix!
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 3 - 10/25
Updated•10 years ago
|
Assignee: nobody → brion
You need to log in
before you can comment on or make changes to this bug.
Description
•