929677 - Please schedule a mozharness run that includes scripts/gaia_integration.py on cedar

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

I would like to stage a build that includes the new https://github.com/mozilla/build-mozharness/blob/master/scripts/gaia_integration.py script on the cedar staging branch.

Comment 1

[Armen [:armenzg]]

Moving it to General Automation so it can be triaged.

Comment 2

[Jonathan Griffin (:jgriffin)]

(In reply to Gareth Aye [:gaye] from comment #0)
> I would like to stage a build that includes the new
> https://github.com/mozilla/build-mozharness/blob/master/scripts/
> gaia_integration.py script on the cedar staging branch.

It looks like we need a config file for this still; Gareth, can you tell us what parameters you usually pass to this script, if any?

Comment 3

[Jonathan Griffin (:jgriffin)]

It's possible we could use http://hg.mozilla.org/build/mozharness/file/7bf07524c01b/configs/b2g/gaia_unit_production_config.py, or a close cousin.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

That seems perfect. I have an extra 'npm_registry' that I define here http://hg.mozilla.org/build/mozharness/file/7bf07524c01b/mozharness/base/gaia_test.py, but it defaults to what I want. Can we reuse the gaia_unit_production_config.py?

Comment 5

[Jonathan Griffin (:jgriffin)]

That should work.

Comment 6

[Jonathan Griffin (:jgriffin)]

Attachment: Schedule gaia-integration tests on cedar,

This schedules the tests on opt linux32/64 b2g desktop builds, cedar-only.

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

+1

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 821296 [details] [diff] [review]
Schedule gaia-integration tests on cedar,

Thanks!

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 821296 [details] [diff] [review]
Schedule gaia-integration tests on cedar,

Review of attachment 821296 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbot-configs/rev/f6abc48f2696

Gareth, this won't be live until the next buildbot reconfig, either Thursday or Monday.

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Jonathon - Can you needinfo me here or ping me on irc when that happens? When it comes to buildbot http://i1.kym-cdn.com/photos/images/newsfeed/000/234/786/bf7.gif

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

s/Jonathon/Jonathan/ ::facepalm:: sorry!

Comment 12

[Justin Wood (:Callek)]

in production

Comment 13

[Jonathan Griffin (:jgriffin)]

This is live on cedar now, but failing due to a bug in the mozharness script:

11:42:09     INFO - #####
11:42:09     INFO - ##### Running run-tests step.
11:42:09     INFO - #####
11:42:09     INFO - Running pre-action listener: _resource_record_pre_action
11:42:09     INFO - Running main action method: run_tests
11:42:09     INFO - Running command: ['make test-integration'] in /builds/slave/test/gaia
11:42:09     INFO - Copy/paste: "make test-integration"
11:42:09     INFO - Using env: {'MOCHA_REPORTER': 'mocha-tbpl-reporter',
11:42:09     INFO -  'NPM_REGISTRY': 'http://npm-mirror.pub.build.mozilla.org'}
11:42:09    ERROR - caught OS error 2: No such file or directory while running ['make test-integration']

At a glance, I'd say that the command needs to be specified as ['make', 'test-integration'].

Comment 14

[Jonathan Griffin (:jgriffin)]

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=29673705&tree=Cedar&full=1#error0

Comment 15

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Patch for gaia_integration.py make issue

Jonathan or Aki,

Hey if either of you are around today would you mind reviewing and pushing my patch for me? I think it was just an issue with passing "make test-integration" to script#query_exe like Jonathan mentioned.

Comment 16

[Jonathan Griffin (:jgriffin)]

Comment on attachment 822773 [details] [diff] [review]
Patch for gaia_integration.py make issue

Review of attachment 822773 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change below.

::: scripts/gaia_integration.py
@@ +31,5 @@
>          # `make test-integration \
>          #      MOCHA_REPORTER=mocha-tbpl-reporter \
>          #      NPM_REGISTRY=http://npm-mirror.pub.build.mozilla.org`
> +        make = self.query_exe('make', return_type='list')
> +        cmd = [make, 'test-integration']

Since the return_type of make is 'list', what you want is probably something like:

cmd = make + ['test-integration']

Comment 17

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Updated patch to fix make command

Hi Jonathan,

Thanks for taking a look. Obviously my python chops are not all the way there yet :). I changed the return_type to string. Would you mind pushing this to hg.mozilla.org/build/mozharness for me? I filed a bug for commit access, but I think the message hasn't gotten to the hg servers yet.

Comment 18

[Jonathan Griffin (:jgriffin)]

Comment on attachment 822890 [details] [diff] [review]
Updated patch to fix make command

https://hg.mozilla.org/build/mozharness/rev/00db6f60cf7f

Comment 19

[Gareth Aye [:gaye] (back from PTO)]

Thanks!

Comment 20

[Jonathan Griffin (:jgriffin)]

These are running; separate bugs will be used to address harness failures.

Comment 21

[Aki Sasaki (not active)]

(In reply to Gareth Aye [:gaye] from comment #17)
> Thanks for taking a look. Obviously my python chops are not all the way
> there yet :). I changed the return_type to string.

It's probably fine here, but it's best practice to match the return_type to the way you'll use it.

If self.query_exe('make', return_type='string') returns 'python path/to/pymake.py', then the command ['python path/to/pymake.py', 'test-integration'] will break.  Since this isn't going to run on windows (afaik), the chance of a 'make' of more than one "word" is slim, so this is probably fine.

Comment 22

[Rail Aliiev [:rail]]

In production

Comment 23

[Gareth Aye [:gaye] (back from PTO)]

I saw these up before, but I don't see them anymore on https://tbpl.mozilla.org/?tree=Cedar. Were they turned off?

Comment 24

[Jonathan Griffin (:jgriffin)]

No, they're just hidden (since they're broken); use https://tbpl.mozilla.org/?tree=Cedar&showall=1 to see.

Comment 25

[Gareth Aye [:gaye] (back from PTO)]

Ah my bad. Thanks!