929763 - Enabling profiler add-on on local builds causes a crash

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Not sure when this started happening, but for local builds, if I try to enable the Gecko Profiler add-on, I immediately crash.

This is not the case with Nightly builds, which is pretty frustrating.

Here's a stack trace:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x00000000000150b2
0x0000000102142d24 in TickSample::PopulateContext (this=0x7fff5fbe7d60, aContext=0x0) at /Users/mikeconley/Projects/ux/tools/profiler/platform-macos.cc:419
419	  asm (
(gdb) bt
#0  0x0000000102142d24 in TickSample::PopulateContext (this=0x7fff5fbe7d60, aContext=0x0) at /Users/mikeconley/Projects/ux/tools/profiler/platform-macos.cc:419
#1  0x00000001021380c7 in TableTicker::GetBacktrace (this=0x11c3dc700) at /Users/mikeconley/Projects/ux/tools/profiler/TableTicker.cpp:627

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Backing out bug 921330 seems to fix things locally... tentatively marking as blocking.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

We should only be calling TickSample::PopulateContext if HAVE_NATIVE_UNWIND is set.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 820702 [details] [diff] [review]
Patch

Review of attachment 820702 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fast response!

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Try build:
https://tbpl.mozilla.org/?tree=Try&rev=a7254ec10510

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4f0cba097a

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ac4f0cba097a