Closed
Bug 930845
Opened 11 years ago
Closed 6 years ago
Remove unused "expander" binding and expander.xml
Categories
(Toolkit :: UI Widgets, task)
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: WeirdAl, Assigned: u605551)
References
()
Details
(Whiteboard: [xbl-remove-unused][xbl-available])
Attachments
(1 file, 1 obsolete file)
|
6.26 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
As far as I can tell, no Firefox code uses it. But it's been in the toolkit forever. There's no documentation on MDN about it, either. It might be the least supported widget (and that's saying something)... Really, we should see if it's a candidate for removal as dead code. Or we should support it with documentation and a mochitest.
|
Reporter | |
Updated•11 years ago
|
|
||
Comment 1•7 years ago
|
||
I still don't see any usage either, so I believe it can be removed: https://searchfox.org/mozilla-central/source/toolkit/content/xul.css#1159 https://searchfox.org/mozilla-central/source/toolkit/content/widgets/expander.xml https://searchfox.org/mozilla-central/search?q=expander
Blocks: war-on-xbl, 1387013
Summary: XUL expander widget needs a test - or needs removal → Remove unused "expander" binding and expander.xml
|
|
||
Updated•7 years ago
|
Whiteboard: [xbl-remove-unused]
|
|
||
Updated•7 years ago
|
Whiteboard: [xbl-remove-unused] → [xbl-remove-unused][xbl-available]
Attachment #8931855 -
Flags: review?(enndeakin)
|
|
||
Updated•7 years ago
|
Assignee: nobody → 86ecce74
Status: NEW → ASSIGNED
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8931855 [details] [diff] [review] Removed expander binding and expander.xml You should also remove expander.css
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8931855 [details] [diff] [review] Removed expander binding and expander.xml See above comment.
Attachment #8931855 -
Flags: review?(enndeakin) → review-
Attachment #8931855 -
Attachment is obsolete: true
Flags: needinfo?(86ecce74)
|
||
Updated•6 years ago
|
Attachment #8940288 -
Flags: review?(enndeakin)
|
|
||
Updated•6 years ago
|
Attachment #8940288 -
Flags: review?(enndeakin) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/be780bf2c08a Removed expander binding, expander.css and expander.xml; r=enn
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/be780bf2c08a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•5 years ago
|
Type: defect → task
You need to log in
before you can comment on or make changes to this bug.
Description
•