93087 - nsPref's constructor leaks mDefaultBranch

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsPref's constructor leaks mDefaultBranch by never releasing the reference
obtained by the |GetDefaultBranch| call (since the nsCOMPtr mDefaultBranch
|AddRef|s again when assigned into).

Patch coming.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Brian Nesse (gone)]

We really need to get rid of nsPref...

r=bnesse.

Comment 3

[Chris Waterson]

sr=waterson

Comment 4

[sairuh (rarely reading bugmail)]

rodney, feel free to punt back if you don't want this one!

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-08-02 19:36 PDT.

Comment 6

[Rodney Velasco]

david, brian.  How would one verify this bug?

Comment 7

[Brian Nesse (gone)]

It's a code only change. There's really no QA quantifiable to validate it.

Comment 8

[sairuh (rarely reading bugmail)]

okay then --rubberstamp. :)