930944 - device can not reboot/poweroff successful

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[viral [:viralwang]]

We met device can not reboot/poweroff successful in unagi and flatfish.

reboot/poweroff will be blocked since device enter suspend mode and freeze the userspace processes.
We need to wake up acpu again to resume device and complete reboot/poweroff.

reproduce steps:
1. use master gecko/gaia in unagi.
2. make sure no USB attached
3. long press power key and choose Restart

The reboot can not complete immediately, we can only found screen is off.
device will be reboot when acpu wake up (such as press power key and plug in USB)

Comment 1

[viral [:viralwang]]

Hi Rex,

I'm guessing the code here is used to turn screen off.

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sleep_menu.js#L305

however, it will make the device suspend and block all the userspace processes included poweroff and reboot.
Could you please help to take a look?
Thanks.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Not sure if it's a regression.
We may not need to turn off screen when power-off as well, but I need some test to confirm it.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

It's true that screenoff suspends all following actions. Let's try not to
screenoff before reboot/poweroff..
Tested OK for me both with/without custom boot animation.

Alive may you help review this simple patch?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 823868 [details]
patch

r+ if UI looks O.K. after this change.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thank you Alive!

merged here:
https://github.com/mozilla-b2g/gaia/commit/1a5daa90ac49e1e83dc7902acc461acdb3606dde

Comment 6

[viral [:viralwang]]

Since it's a generic issue, shall we also apply it on 1.2?

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: this is a regression caused by power off animation implementation. koi+

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1a5daa90ac49e1e83dc7902acc461acdb3606dde to:
v1.2: eb707a60302e86add4ec1beba3519ab957cdf3a8