Closed
Bug 93107
Opened 23 years ago
Closed 22 years ago
'Save Attachment' dialogs title located in msgbase.dll
Categories
(MailNews Core :: Internationalization, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.2alpha
People
(Reporter: annac, Assigned: ssu0262)
References
Details
(Keywords: l12y)
Attachments
(1 file)
2.26 KB,
patch
|
ssu0262
:
review+
mscott
:
superreview+
asa
:
approval+
|
Details | Diff | Splinter Review |
Selecting 'Save As' for a received attachment in mail opens a dialog titled 'Save Attachment'. This title text appears to be coming from msgbase.dll and is therefore unlocalisable. Steps to Repro. 1. Launch mail and setup a valid account 2. Send this account a mail including an attachment 3 [details] [diff] [review]. Right click on the received mail and select 'Save As'
Comment 1•23 years ago
|
||
/mailnews/base/src/nsMessenger.cpp, line 395 -- NS_NAMED_LITERAL_STRING(saveAttachmentTag, "Save Attachment"); /mailnews/base/src/nsMessenger.cpp, line 685 -- GetString(NS_ConvertASCIItoUCS2("Save Attachment").get()),
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•23 years ago
|
||
MScott is this one gonna be fixed any time soon (i.e. TM0.9.4)?
Comment 4•23 years ago
|
||
Marking nsbranch- as it was decided in the August bug triage that we wouldn't have enough time in eMojo to fix this. Let's revisit for MachV.
Keywords: nsbranch-
Comment 5•23 years ago
|
||
removed keyword nsbranch since bug now has nsbranch-, per pdt mtg.
Keywords: nsbranch
Updated•23 years ago
|
Comment 8•23 years ago
|
||
*** Bug 108602 has been marked as a duplicate of this bug. ***
Comment 9•23 years ago
|
||
need to do "Save All Attachments" as well.
Summary: 'Save Attchment' dialog title located in msgbase.dll → 'Save Attachment' dialogs title located in msgbase.dll
Updated•23 years ago
|
Priority: -- → P3
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.9
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P2
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.0
Updated•23 years ago
|
Comment 10•23 years ago
|
||
Both "Save attachment" and "Save all attachments" are hardcoded in: mailnews/base/src/nsMessenger.cpp ji, is this for Windows only? Looks Mac has same problem...
Comment 12•23 years ago
|
||
sean: Attached should fix your problem.
Comment 13•22 years ago
|
||
Michele, since this has a patch already, should we mark this as nsbeta1+? This is kind of critical for l10n.
Assignee | ||
Comment 14•22 years ago
|
||
Comment on attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties thanks for the patch Roy. r=ssu looking for sr= now.
Attachment #71949 -
Flags: review+
Comment 15•22 years ago
|
||
Comment on attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties sr=mscott
Attachment #71949 -
Flags: superreview+
Comment 17•22 years ago
|
||
Comment on attachment 71949 [details] [diff] [review] use StringBundle to retrieve texts in messenger.properties a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #71949 -
Flags: approval+
Assignee | ||
Comment 18•22 years ago
|
||
roy's patch checked in to trunk only.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 19•22 years ago
|
||
ji, you can verify this bug now. I just tested 02-03-07 trunk, by modifying the file in language pack, "Save attachment" and "Save all attachment" can be easily localized like Japanese.
Comment 20•22 years ago
|
||
Marked it as verified. Ying, thanks for the help.
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•