931467 - Make QS/DOM binding unwrapping like XPCConvert unwrapping for COWs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: Port hack from XPCConvert unwrapping to XPCQuickStubs

This came up in bug 918345 (see bug 918345 comment 9).

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 822882 [details] [diff] [review]
Port hack from XPCConvert unwrapping to XPCQuickStubs

Review of attachment 822882 [details] [diff] [review]:
-----------------------------------------------------------------

r=bholley with the below.

::: js/xpconnect/src/XPCQuickStubs.cpp
@@ +537,5 @@
> +        // Hack - For historical reasons, wrapped chrome JS objects have been
> +        // passable as native interfaces. We'd like to fix this, but it
> +        // involves fixing the contacts API and PeerConnection to stop using
> +        // COWs. This needs to happen, but for now just preserve the old
> +        // behavior.

Please add a comment here indicating that this is duplicated in XPCConvert, and a comment in the XPCConvert code indicating the same thing. Otherwise, I'll miss this when I land bug 821573.

Comment 2

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/555f1c5baad7

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/555f1c5baad7