Closed
Bug 931681
Opened 11 years ago
Closed 11 years ago
[Marionette] Modify the output format for repeat option
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: askeing, Assigned: askeing)
Details
Attachments
(1 file, 1 obsolete file)
|
1.59 KB,
patch
|
askeing
:
review+
askeing
:
feedback+
|
Details | Diff | Splinter Review |
The output of repeat option is a little bit weird now. For example, with "--repeat=4" option, the output will be: ROUND 4 ------- xxx... (1st run) ROUND 3 ------- xxx... (1st run) ROUND 2 ------- xxx... ROUND 1 ------- xxx... ROUND 0 ------- xxx... SUMMARY ------- passed: X failed: Y todo: Z
|
Assignee | |
Comment 1•11 years ago
|
||
(In reply to Askeing Yen[:askeing] from comment #0) > The output of repeat option is a little bit weird now. > For example, with "--repeat=4" option, the output will be: ROUND 4 ------- xxx... (1st run) ROUND 3 ------- xxx... (2nd run) ROUND 2 ------- xxx... (3rd run) ROUND 1 ------- xxx... (4th run) ROUND 0 ------- xxx... (5th run) SUMMARY ------- passed: X failed: Y todo: Z Sorry for the typo.
|
|
Assignee | |
Comment 2•11 years ago
|
||
IMO, the following output format will be better for "--repeat=4" option: xxx... (1st run) REPEAT 1 ------- xxx... (2nd run) REPEAT 2 ------- xxx... (3rd run) REPEAT 3 ------- xxx... (4th run) REPEAT 4 ------- xxx... (5th run)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 823199 [details] [diff] [review] bug-931681-fix.patch Review of attachment 823199 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. I especially like the removal of the 'ROUND 0' for when the --repeat argument is not specified. Requesting feedback from Zac too.
Attachment #823199 -
Flags: feedback?(zcampbell)
Attachment #823199 -
Flags: feedback?
Attachment #823199 -
Flags: feedback+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4c969a990a11
|
||
Comment 6•11 years ago
|
||
Comment on attachment 823199 [details] [diff] [review] bug-931681-fix.patch A non-technical r+ from me. I like it very much, it sounds much less like a boxing match now :)
Attachment #823199 -
Flags: feedback?(zcampbell) → feedback+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Comment on attachment 823199 [details] [diff] [review] bug-931681-fix.patch review?
Attachment #823199 -
Flags: review?
|
||
Updated•11 years ago
|
Attachment #823199 -
Flags: review? → review+
|
|
||
Comment 8•11 years ago
|
||
No reviewer was listed, so I just chimed in. Feel free to land on m-i.
|
|
Assignee | |
Comment 9•11 years ago
|
||
modified the comment of patch.
Attachment #823199 -
Attachment is obsolete: true
Attachment #825081 -
Flags: review+
Attachment #825081 -
Flags: feedback+
|
|
Assignee | |
Comment 10•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4c969a990a11
|
|
Assignee | |
Comment 11•11 years ago
|
||
Hi jgriffin, could you please help us to land this patch? Thank you.
Flags: needinfo?(jgriffin)
|
||
Comment 12•11 years ago
|
||
The trees are currently closed; I'll land this when they re-open.
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Updated•11 years ago
|
Flags: needinfo?(jgriffin)
|
||
Comment 13•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/a33e3cb6c17d
Assignee: nobody → fyen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a33e3cb6c17d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•