931911 - crash in mozilla::a11y::SelectionManager::ProcessSelectionChanged(nsISelection*)

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Tracy Walker [:tracy]]

This bug was filed from the Socorro interface and is 
report bp-385aef50-37c3-4b46-abec-87c312131028.
=============================================================

several comments indicate attempting to compose an email in gmail.

Most of these crashes are on Win 8/8.1

Comment 1

[Marco Zehe (:MarcoZ)]

Alex, is this due to the text selection event reorg?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Marco Zehe (:MarcoZ) from comment #1)
> Alex, is this due to the text selection event reorg?

it is, simple null check will help

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 4

[u279076]

7-day Nightly Rank:
 * Firefox 27.0a1: #3 (19.20%)
 * Firefox 28.0a1: #2 (13.37%)

Comment 5

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1a486a62b1f3

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1a486a62b1f3

Comment 7

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

We're gonna fix this in Aurora too, right? I can't compose emails currently

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 823959 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 928504
User impact if declined: crashes
Testing completed (on m-c, etc.): yes
Risk to taking this patch (and alternatives if risky): no risk
String or IDL/UUID changes made by this patch: no

Comment 9

[u279076]

Is this really fixed? I'm still seeing over 300 crashes reported with build IDs after 2013-11-01:
https://crash-stats.mozilla.com/report/list?product=Firefox&range_value=7&range_unit=days&date=2013-11-04&signature=mozilla%3A%3Aa11y%3A%3ASelectionManager%3A%3AProcessSelectionChanged%28nsISelection*%29&version=Firefox%3A28.0a1

Comment 10

[Tracy Walker [:tracy]]

Sort the Reports tab by build ID. There are no reports of 28.0a1 builds crashing after 20131101030205.

I have no idea why the Table tab shows data for more recent builds.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/51ae975337bf

Comment 12

[Robert Kaiser]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #10)
> Sort the Reports tab by build ID. There are no reports of 28.0a1 builds
> crashing after 20131101030205.
> 
> I have no idea why the Table tab shows data for more recent builds.

The Reports tab has multiple pages, but sorting only sorts the current page and not the whole list. The Table tab probably samples the whole list.

Comment 13

[Tracy Walker [:tracy]]

There are no reports of this happening with builds from 11/5 or 11/6.