932015 - Ship branding favicon inside Android resources

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Richard Newman [:rnewman]]

We load

jar:jar:file:///data/app/org.mozilla.fennec_rnewman-1.apk!/assets/omni.ja!/chrome/chrome/content/branding/favicon64.png

from the JAR on startup. Then we write it into the DB, from which we load it every time we start.

We should be doing something smarter, like loading it from resources.

Comment 1

[Nick Alexander :nalexander [he/him]]

Sigh.  Until Bug 928151 lands, this is going to be ugly.  But:

Add the favicon{32,64}.png files to ANDROID_GENERATED_RESFILES in m/a/b/moz.build.  Duplicate the icon .png logic in Makefile.in to install the files from branding into $OBJDIR/m/a/b/res.  Hate yourself.

Comment 2

[Richard Newman [:rnewman]]

Note that on a shitty Moto RAZR XT910 with Android 2.3, fetching the icon from the JAR takes 4msec. Loading from resources is unlikely to be a giant win…

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.