Closed
Bug 932216
Opened 11 years ago
Closed 11 years ago
Remove code conditional on JS_HAS_CONST, JS_HAS_BLOCK_SCOPE
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: wingo, Assigned: wingo)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
15.90 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Const is a part of the web. Let will be a part of ES6, somehow. Remove code conditional on these defines, and reword Keywords.h to reflect 1JS.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → wingo
Assignee | ||
Updated•11 years ago
|
Attachment #823911 -
Flags: review?(jorendorff)
Comment 2•11 years ago
|
||
Perhaps JS_HAS_DESTRUCTURING as well?
Updated•11 years ago
|
Attachment #823911 -
Flags: review?(jorendorff) → review+
Comment 3•11 years ago
|
||
(In reply to Andy Wingo [:wingo] from comment #0) > Const is a part of the web. Oh?
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to :Ms2ger from comment #3) > (In reply to Andy Wingo [:wingo] from comment #0) > > Const is a part of the web. > > Oh? Sure. Not defined, but treating it as a token is web-compatible. Also it will be in ES6.
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Luke Wagner [:luke] from comment #2) > Perhaps JS_HAS_DESTRUCTURING as well? A good idea; didn't think of it because I was just concerned about the keyword list :)
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/13bd430455d4
Keywords: checkin-needed
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/13bd430455d4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•