932274 - Use Moz2D size classes in ipdl

Status: NEW

(Core :: General, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

David, can you put the comments into the bug as to why we're doing this? I'm not suggesting we don't have a good reason, just that we should write it down so that it's obvious a few years from now.  Thanks.

Comment 2

[David Zbarsky (:dzbarsky)]

(In reply to Milan Sreckovic [:milan] from comment #1)
> David, can you put the comments into the bug as to why we're doing this? I'm
> not suggesting we don't have a good reason, just that we should write it
> down so that it's obvious a few years from now.  Thanks.

We want to transition away from using nsIntSize and gfxIntSize and instead use gfx::IntSize or more specific size classes (like ScreenIntSize) when possible.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bad6c063b01f

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/6e221af28de2 for breaking the build for at least Windows: https://tbpl.mozilla.org/php/getParsedLog.php?id=30097699&tree=Mozilla-Inbound and B2G desktop Windows: https://tbpl.mozilla.org/php/getParsedLog.php?id=30097498&tree=Mozilla-Inbound

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Hmm, the non-Windows, non-b2g-desktop-Windows failures actually parsed out an error: https://tbpl.mozilla.org/php/getParsedLog.php?id=30098888&tree=Mozilla-Inbound

../../../gecko/gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp:497: error: conversion from 'const mozilla::gfx::IntSizeTyped<mozilla::gfx::UnknownUnits>' to non-scalar type 'gfxIntSize' requested
../../../gecko/gfx/layers/ipc/ShadowLayerUtilsGralloc.cpp:535: error: no match for 'operator=' in '* aSize = ((const mozilla::layers::SurfaceDescriptorGralloc*)((const mozilla::layers::SurfaceDescriptor*)aDescriptor)->mozilla::layers::SurfaceDescriptor::get_SurfaceDescriptorGralloc())->mozilla::layers::SurfaceDescriptorGralloc::size()'
make[6]: *** [ShadowLayerUtilsGralloc.o] Error 1
make[5]: *** [gfx/layers/compile] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [realbuild] Error 2
make[1]: *** [build] Error 2
make: *** [out/target/product/generic/obj/DATA/gecko_intermediates/gecko] Error 2
Return code: 2
failed to build