933102 - [e10s] Filter UDP packets sent with hostname

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

In bug 870660, we add filters to filter the UDP packets which child process asks parent to send. However, it doesn't filter packets that is going to be sent with a hostname. If UDPSocketParent received a packet that is sent to a hostname (not an IP address) and passing filter is required, it simply refuses to send the packet.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

What higher-level features does this block?

Comment 2

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

(In reply to Randell Jesup [:jesup] from comment #1)
> What higher-level features does this block?

I don't think there is any higher-level feature currently depends on this.

Comment 3

[Nils Ohlmeier [:drno]]

I guess the question here is if we really need this. If I'm not mistaken nICEr never will send anything with a host name as it always does it's own DNS resolution. And if there is no other customer for packet filtering, then we can probably safely close this ticket.

Comment 4

[Nils Ohlmeier [:drno]]

Byron: do you think it is safe to abandon this?

Comment 5

[Nils Ohlmeier [:drno]]

It is referenced here: https://dxr.mozilla.org/mozilla-central/source/dom/network/UDPSocketParent.cpp#377

Comment 6

[Byron Campen [:bwc]]

WebRTC doesn't need this, but there may be other reasons.

Comment 7

[Nils Ohlmeier [:drno]]

According to dxr stun_udp_socket_filter.cpp is the only place which implements the filter: https://dxr.mozilla.org/mozilla-central/source/media/mtransport/stun_udp_socket_filter.cpp#208