Closed Bug 933135 Opened 11 years ago Closed 11 years ago

Treat SIMPLE_PROGRAMS more like PROGRAM

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attachment #825139 - Flags: review?(gps)
Attachment #825139 - Attachment is obsolete: true
Attachment #825139 - Flags: review?(gps)
Comment on attachment 825144 [details] [diff] [review]
Treat SIMPLE_PROGRAMS more like PROGRAM

Since gps is on PTO, let's see if mshal can get here first.
Attachment #825144 - Flags: review?(mshal)
Comment on attachment 825144 [details] [diff] [review]
Treat SIMPLE_PROGRAMS more like PROGRAM

These changes look good to me.

Is there any reason to still require the files be in both SOURCES and SIMPLE_PROGRAMS? We could just do:

SIMPLE_PROGRAMS += [
    'bar.c',
    'foo.cpp',
]

And handle the rest in mozbuild.
Attachment #825144 - Flags: review?(mshal) → review+
Attachment #825144 - Flags: review?(gps)
(In reply to Michael Shal [:mshal] from comment #4)
> Is there any reason to still require the files be in both SOURCES and
> SIMPLE_PROGRAMS?

Let's do this in a followup.
https://hg.mozilla.org/mozilla-central/rev/c2e496209608
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: