Closed
Bug 933135
Opened 11 years ago
Closed 11 years ago
Treat SIMPLE_PROGRAMS more like PROGRAM
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla28
People
(Reporter: glandium, Assigned: glandium)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
26.09 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #825139 -
Flags: review?(gps)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #825144 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Attachment #825139 -
Attachment is obsolete: true
Attachment #825139 -
Flags: review?(gps)
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 825144 [details] [diff] [review] Treat SIMPLE_PROGRAMS more like PROGRAM Since gps is on PTO, let's see if mshal can get here first.
Attachment #825144 -
Flags: review?(mshal)
Comment 4•11 years ago
|
||
Comment on attachment 825144 [details] [diff] [review] Treat SIMPLE_PROGRAMS more like PROGRAM These changes look good to me. Is there any reason to still require the files be in both SOURCES and SIMPLE_PROGRAMS? We could just do: SIMPLE_PROGRAMS += [ 'bar.c', 'foo.cpp', ] And handle the rest in mozbuild.
Attachment #825144 -
Flags: review?(mshal) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #825144 -
Flags: review?(gps)
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #4) > Is there any reason to still require the files be in both SOURCES and > SIMPLE_PROGRAMS? Let's do this in a followup.
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e496209608
https://hg.mozilla.org/mozilla-central/rev/c2e496209608
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•