Closed
Bug 933946
Opened 11 years ago
Closed 11 years ago
Remove the rest of the old number conversion functions
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
10.61 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
We had JS_ValueToInt32, which is incompatible with ECMA. Luckily it wasn't used in anything, but some testing functions. I wasn't sure what to do about ConvertArguments, should we throw for "j"?
Attachment #826094 -
Flags: review?(terrence)
Comment 1•11 years ago
|
||
Comment on attachment 826094 [details] [diff] [review] remove-number Review of attachment 826094 [details] [diff] [review]: ----------------------------------------------------------------- Nice! r=me Be sure to update the wiki. (Although I seem to recall that this method may already be undocumented.) ::: js/src/jsapi.h @@ +1110,3 @@ > > namespace js { > +/* DO NOT CALL THIS. Use JS::ToUint16. */ One space between sentences. ::: js/xpconnect/src/XPCShellImpl.cpp @@ +395,5 @@ > return false; > } > > nsCOMPtr<nsIXPConnect> xpc = do_GetService(nsIXPConnect::GetCID()); > + if(xpc) Space between if and (.
Attachment #826094 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65815cafbece
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65815cafbece
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•