933997 - Trying to load an online support link from the Settings Help Menu loads a settings app error page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Jason Smith [:jsmith]]

Attachment: Screenshot

Build: 11/1 Buri 1.2 Build

STR

1. Setup your build according to https://wiki.mozilla.org/B2G/QA/Customizations#Build_Setup with a AT&T SIM included
2. Go to settings --> help
3. Select the online support link

Expected

The URL at the online support link should load.

Actual

A browser error page is reported - see screenshot.

Comment 1

[Preeti Raghunath(:Preeti)]

Users are impacted by not being able to see a help page. This also breaks SIM customization.

Comment 2

[:gerard-majax]

I'm looking into this.

Comment 3

[:gerard-majax]

Dumb question, what is the expected UX when we have no network ?

Comment 4

[Jason Smith [:jsmith]]

(In reply to Alexandre LISSY :gerard-majax from comment #3)
> Dumb question, what is the expected UX when we have no network ?

If you are within an app, it should display an offline error modal dialog that states that there is no network connection. On the modal dialog, a user is allowed to cancel or try again.

Comment 5

[:gerard-majax]

The AT&T support website is Youtube ?

Comment 6

[:gerard-majax]

(In reply to Jason Smith [:jsmith] from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > Dumb question, what is the expected UX when we have no network ?
> 
> If you are within an app, it should display an offline error modal dialog
> that states that there is no network connection. On the modal dialog, a user
> is allowed to cancel or try again.

So, if the user has no network connection when tapping on the support link, we should have this modal dialog error ?

Comment 7

[Jason Smith [:jsmith]]

(In reply to Alexandre LISSY :gerard-majax from comment #5)
> The AT&T support website is Youtube ?

That's just my test URL I'm using to test customizations out. I was using google.com & youtube.com as test URLs to test this feature.

Comment 8

[:gerard-majax]

Okay, I actually do reproduce the issue.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Alexandre LISSY :gerard-majax from comment #6)
> (In reply to Jason Smith [:jsmith] from comment #4)
> > (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > > Dumb question, what is the expected UX when we have no network ?
> > 
> > If you are within an app, it should display an offline error modal dialog
> > that states that there is no network connection. On the modal dialog, a user
> > is allowed to cancel or try again.
> 
> So, if the user has no network connection when tapping on the support link,
> we should have this modal dialog error ?

Yes. Although in this bug's case, there was an internet connection, so we should have opened the browser with the target online support link.

Comment 10

[:gerard-majax]

(In reply to Jason Smith [:jsmith] from comment #9)
> (In reply to Alexandre LISSY :gerard-majax from comment #6)
> > (In reply to Jason Smith [:jsmith] from comment #4)
> > > (In reply to Alexandre LISSY :gerard-majax from comment #3)
> > > > Dumb question, what is the expected UX when we have no network ?
> > > 
> > > If you are within an app, it should display an offline error modal dialog
> > > that states that there is no network connection. On the modal dialog, a user
> > > is allowed to cancel or try again.
> > 
> > So, if the user has no network connection when tapping on the support link,
> > we should have this modal dialog error ?
> 
> Yes. Although in this bug's case, there was an internet connection, so we
> should have opened the browser with the target online support link.

Yep. I think I located the issue: when we do the request to get the support.onlinesupport.href value, we add a onsuccess callback, but inside this callback we access ['support.onlinesupport.href'] in the requets object instead of the .result object.

Comment 11

[:gerard-majax]

Okay so I think we have another bug here, when we have no network connection. I'll open a follow up.

Comment 12

[:gerard-majax]

Attachment: Link

Please find attached a link to the github pull request

Comment 13

[Aus Lacroix [:aus]]

Comment on attachment 828265 [details] [review]
Link

Looks good!

Comment 14

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/commit/df92f0ebd89efbc63570a61e70c4304c17b8b555

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted df92f0ebd89efbc63570a61e70c4304c17b8b555 to:
v1.2: de60d333a3056d098ec5159a81c212f28b3e6a6c

Comment 16

[Jason Smith [:jsmith]]

lgtm on 1.2